prepare_shell_job_inputs: metadata.computer not forwarded to CalcJob for PortableCode

[rikigigi]

metadata.computer is popped:

aiida-shell/src/aiida_shell/launch.py

Line 129 in 64249d9

computer = metadata.pop('computer', None)

if I use a PortableCode (without the computer defined) this works only if I specify both metadata.options.computer and metadata.computer, so that the (wrong?) logic pops only the first one and not the second.

I think metadata.computer should not be popped...

Is my reasoning correct? As it is now PortableCodes work only with this strange workaround?

thank you

[t-reents]

Just for your reference, I encountered the same and the issue should be fixed in #119