馃悰 cd: hold flit_core below 4 - #125
Merged
Merged
Conversation
`flit~=3.4` caps the command line tool below 4, but flit 3.12 requires
only `flit_core>=3.12.0` with no upper bound, so a fresh install pairs
it with `flit_core` 4.x. That major drops the `gen_setup_py` argument
which flit 3.12 still passes, and `flit publish` dies before uploading
anything:
TypeError: SdistBuilder.build() got an unexpected keyword argument
'gen_setup_py'
Pin the library to the same range `build-system.requires` already asks
for, so the publish step builds with the flit_core the package declares
it supports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flit~=3.4caps the command line tool below 4, but flit 3.12 requires onlyflit_core>=3.12.0with no upper bound, so a fresh install pairs it withflit_core4.x. That major drops thegen_setup_pyargument which flit 3.12 still passes, andflit publishdies before uploading anything:Pin the library to the same range
build-system.requiresalready asks for, so the publish step builds with the flit_core the package declares it supports.