Repository navigation
Conversation
|
Could you merge master and also add information to the documentation about this option? |
| class MemcachePool: | ||
|
|
||
| def __init__(self, host, port, *, minsize, maxsize, loop=None): | ||
| def __init__(self, host, port, *, minsize, maxsize, loop=None, unix=None): |
There was a problem hiding this comment.
I think this should accept host/port or unix. Currently a unix connection requires the host/port even though it is unused.
There was a problem hiding this comment.
Or, we could try unix first, and then fallback to host/port if the connection fails. In which case, we should support host/port as None to disable this fallback behaviour and always get an error if the unix connection fails.
|
We also need a new test. So, if you'd like to finish off this PR and get it merged, we need:
Sorry for the delay in reviewing. |
|
@Dreamsorcerer, @vobinics Adding Unix sockets would be a great addition to |
|
Oh, I see this was just merged in #504—thank you! But not yet part of a new release tag. |
These changes do not violate the old code, but complement it
Unix socket connection is 30% faster than TCP
Now, if there is a file along the path /tmp/memcached.sock, then a unix connection is selected
I think this change will help other developers who need a Unix connection.