Repository navigation
feat(mcp): add ALLOW_EXTERNAL_ACCESS and ALLOW_PIPELINE_CHANGES policies for Cloud MCP
#1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aaron ("AJ") Steers (aaronsteers)
merged 4 commits into
release-candidate/v1
from
devin/1789678460-safe-mode-blocks-agents
Oct 5, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
62ca2c5
feat(mcp): add ALLOW_EXTERNAL_ACCESS and ALLOW_PIPELINE_CHANGES polic…
devin-ai-integration[bot] bcd86d0
fix(mcp): keep existing insiders module gate
devin-ai-integration[bot] 99db821
fix(mcp): align policy guidance types with base exception
devin-ai-integration[bot] 0b9eb06
fix(mcp): mention external access header in guidance
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # Copyright (c) 2026 Airbyte, Inc., all rights reserved. | ||
| """Runtime enforcement for MCP tool policies.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING | ||
|
|
||
| from fastmcp.server.middleware import Middleware | ||
|
|
||
| from airbyte.exceptions import ( | ||
| AirbyteExternalAccessDisabledError, | ||
| AirbytePipelineChangesDisabledError, | ||
| ) | ||
| from airbyte.mcp._tool_utils import ( | ||
| external_access_allowed, | ||
| get_tool_policy, | ||
| pipeline_changes_allowed, | ||
| ) | ||
|
|
||
|
|
||
| if TYPE_CHECKING: | ||
| from fastmcp.server.middleware import CallNext, MiddlewareContext | ||
| from fastmcp.tools import ToolResult | ||
| from mcp.types import CallToolRequestParams | ||
|
|
||
|
|
||
| class PolicyGuardMiddleware(Middleware): | ||
| """Enforce pipeline-change and external-access policies before tool execution.""" | ||
|
|
||
| async def on_call_tool( | ||
| self, | ||
| context: MiddlewareContext[CallToolRequestParams], | ||
| call_next: CallNext[CallToolRequestParams, ToolResult], | ||
| ) -> ToolResult: | ||
| """Reject calls denied by effective pipeline or external-access settings.""" | ||
| fastmcp_context = context.fastmcp_context | ||
| if fastmcp_context is None: | ||
| return await call_next(context) | ||
|
|
||
| tool = await fastmcp_context.fastmcp.get_tool(context.message.name) | ||
| if tool is None: | ||
| return await call_next(context) | ||
|
|
||
| policy = get_tool_policy(tool) | ||
| if policy.pipeline_change and pipeline_changes_allowed(fastmcp_context) is False: | ||
| raise AirbytePipelineChangesDisabledError( | ||
| message="Pipeline-changing tools are disabled by the MCP server policy." | ||
| ) | ||
| if policy.external_access and external_access_allowed(fastmcp_context) is False: | ||
| raise AirbyteExternalAccessDisabledError( | ||
| message="External-access tools are disabled by the MCP server policy." | ||
| ) | ||
| return await call_next(context) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.