fix(mcp): surface the SQL passthrough notice in metadata.warnings so MCP renderers show it

airbyte/_direct_connectors/connector_docs.py

@@ -204,7 +204,7 @@ def _destination_connections(destination: _DestinationLike) -> list[_ConnectionL
 def build_direct_access_sql_guidance(
     destination: _DestinationLike,
     *,
-    sql_passthrough_notice: str | None = None,
+    sql_passthrough_warning: str | None = None,
 ) -> DirectAccessGuidance:
     """Build standalone sql guidance when there is no associated skill."""
     dialect = _SQL_PASSTHROUGH_DESTINATION_DIALECTS[destination.definition_id]
@@ -215,11 +215,12 @@ def build_direct_access_sql_guidance(
         title=f"{destination.name} (SQL passthrough destination)",
         summary=f"Table layout and naming for the `{destination.name}` destination.",
         tags=["destination"],
+        warnings=[sql_passthrough_warning] if sql_passthrough_warning else [],
     )
     connections = _destination_connections(destination)
     content: list[dict[str, Any]] = []
-    if sql_passthrough_notice:
-        content.append({"type": "paragraph", "text": sql_passthrough_notice})
+    if sql_passthrough_warning:
+        content.append({"type": "paragraph", "text": sql_passthrough_warning})
     content += _destination_layout_blocks(
         destination=destination,
         dialect=dialect,
@@ -247,7 +248,6 @@ def build_direct_access_sql_guidance(
         outline=[],
         section_id=None,
         content=content,
-        warnings=[sql_passthrough_notice] if sql_passthrough_notice else [],
     )
 
 

airbyte/cloud/connectors.py

@@ -699,7 +699,7 @@ def get_direct_access_guidance(self, *, section: str | None = None) -> DirectAcc
                     )
                 return connector_docs.build_direct_access_sql_guidance(
                     destination,
-                    sql_passthrough_notice=connector_docs.SQL_PASSTHROUGH_UNAVAILABLE_NOTICE,
+                    sql_passthrough_warning=connector_docs.SQL_PASSTHROUGH_UNAVAILABLE_NOTICE,
                 )
             skill_id = connector_docs.destination_skill_id(self.connector_id)
             try:
@@ -716,7 +716,7 @@ def get_direct_access_guidance(self, *, section: str | None = None) -> DirectAcc
                     raise
                 return connector_docs.build_direct_access_sql_guidance(
                     destination,
-                    sql_passthrough_notice=connector_docs.SQL_PASSTHROUGH_NOT_ENABLED_NOTICE,
+                    sql_passthrough_warning=connector_docs.SQL_PASSTHROUGH_NOT_ENABLED_NOTICE,
                 )
             return connector_docs.merge_destination_skill_docs(server_docs, destination)
 

tests/unit_tests/test_cloud_describe.py

@@ -14,6 +14,10 @@
 from airbyte._direct_connectors import api_util as agents_api_util
 from airbyte._direct_connectors import connector_docs
 from airbyte.cloud import workspaces as cloud_workspaces
+from airbyte.mcp._docs_results import (
+    render_agent_skill_docs_result,
+    render_connector_docs_result,
+)
 from airbyte.cloud.connections import CloudConnection
 from airbyte.cloud.connectors import (
     CloudConnector,
@@ -383,7 +387,9 @@ def test_get_direct_access_guidance_destination_not_enabled_adds_notice(
     notice = connector_docs.SQL_PASSTHROUGH_NOT_ENABLED_NOTICE
     guidance = destination.get_direct_access_guidance()
     assert guidance.content[0] == {"type": "paragraph", "text": notice}
-    assert guidance.warnings == [notice]
+    assert guidance.metadata.warnings == [notice]
+    assert render_connector_docs_result(guidance).warnings == [notice]
+    assert render_agent_skill_docs_result(guidance).warnings == [notice]
     assert guidance.outline == []
     assert any(block.get("type") == "table" for block in guidance.content)
     assert "execute_external_sql_query" not in _content_text(guidance)
@@ -520,7 +526,9 @@ def test_get_direct_access_guidance_destination_no_context_layer_notices(
     guidance = destination.get_direct_access_guidance()
     read_docs.assert_not_called()
     assert guidance.content[0] == {"type": "paragraph", "text": notice}
-    assert guidance.warnings == [notice]
+    assert guidance.metadata.warnings == [notice]
+    assert render_connector_docs_result(guidance).warnings == [notice]
+    assert render_agent_skill_docs_result(guidance).warnings == [notice]
     assert guidance.outline == []
     assert "execute_external_sql_query" not in _content_text(guidance)
     assert "SHOW TABLES" not in _content_text(guidance)

tests/unit_tests/test_mcp_cloud.py

@@ -1666,7 +1666,7 @@ def test_describe_helper_fallback_guidance_names_no_tools() -> None:
     connector = _DescribedConnector(connector_type=ConnectorType.DESTINATION)
     connector.guidance = connector_docs.build_direct_access_sql_guidance(
         destination,
-        sql_passthrough_notice=connector_docs.SQL_PASSTHROUGH_NOT_ENABLED_NOTICE,
+        sql_passthrough_warning=connector_docs.SQL_PASSTHROUGH_NOT_ENABLED_NOTICE,
     )
 
     result = _describe(connector, with_direct_access_guidance=True)