refactor(mcp): relay Cloud problem detail instead of the fixed error manifest by calebevans-ab · Pull Request #1368 · airbytehq/PyAirbyte

Caleb Evans (calebevans-ab) · 2026-10-13T02:32:03Z

Summary

Depends on https://github.com/airbytehq/airbyte-platform-internal/pull/19903 for the platform problem-detail wording this PR relays.

Relay Cloud's nonblank detail (then title) through SDK/direct HTTP exceptions, MCP errors, and native Datadog error.message. Remove the fixed YAML catalog; bounded non-problem bodies use only transport-status fallbacks. Only actor-not-ready and 403 retain workflow guidance.

One shared Cloud-chain resolver handles nested wrappers without changing exception classes, validated reason grouping, retries, or non-Cloud trace messages. Agent credential redaction stays downstream; spans receive the selected message without guidance.

Uses the current base's credential redaction rules from #1366: argument values and resource IDs pass through. Caught-error billing messages and connector warnings use the same bounded Cloud formatter and workflow guidance before credential redaction; raw diagnostic context is omitted and successful-result behavior is preserved. No argument-masking behavior is restored. SDK and direct HTTP response bytes are decoded strictly as UTF-8 before message selection.

Validation

All listed commands exited 0:

Latest bearer-redaction follow-up: 336 passed across MCP errors, Cloud results, and native Datadog tests; uv run poe check and uv run ruff format --check . passed.
Previous warning/billing follow-up: 445 passed across Cloud warnings, billing, credentials, and direct access.
uv run poe check
uv run ruff format --check .
Full unit suite before the bearer-redaction follow-up: uv run poe test-unit-tests, 2,028 passed, 2 existing skips.
uv run pyrefly check

Includes real FastMCP/native Datadog tests and malformed JSON, Unicode, byte-boundary, nesting, large-integer, strict response-byte decoding, and successful-result credential redaction regressions. Independent review of the latest fixes found no remaining issues.

Revert this commit to restore the catalog and consumers together. No migrations.

github-actions · 2026-10-13T02:32:30Z

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

Testing This PyAirbyte Version

You can test this version of PyAirbyte using the following:

# Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@codex/cloud-problem-detail-relay' pyairbyte --help

# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@codex/cloud-problem-detail-relay'

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

/fix-pr - Fixes most formatting and linting issues
/uv-lock - Updates uv.lock file
/test-pr - Runs tests with the updated PyAirbyte
/prerelease - Builds and publishes a prerelease version to PyPI

📚 Show Repo Guidance

Helpful Resources

Community Support

Questions? Join the #pyairbyte channel in our Slack workspace.

📝 Edit this welcome message.

github-code-quality · 2026-10-13T02:36:40Z

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest-no-creds

The overall line coverage in commit ed10157 in the codex/cloud-problem-... branch is 79%. The line coverage in commit d9f652f in the release-candidate/v1 branch is 65%.

Show a line coverage summary of the most impacted files.

File	`release-candidate/v1` d9f652f	`codex/cloud-problem-...` ed10157	+/-
`airbyte/mcp/cloud.py`	52%	83%	+31%
`airbyte/_util/api_util.py`	36%	68%	+32%
`airbyte/cloud/connectors.py`	34%	75%	+41%
`airbyte/mcp/_datadog.py`	0%	50%	+50%
`airbyte/mcp/_user_identity.py`	0%	93%	+93%
`airbyte/_direct...ctors/models.py`	0%	94%	+94%
`airbyte/mcp/_telemetry.py`	0%	94%	+94%
`airbyte/mcp/_sso_auth.py`	0%	96%	+96%
`airbyte/cloud/models.py`	0%	97%	+97%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%

Python / code-coverage/pytest

The overall line coverage in commit ed10157 in the codex/cloud-problem-... branch is 81%. The line coverage in commit d9f652f in the release-candidate/v1 branch is 71%.

Show a line coverage summary of the most impacted files.

File	`release-candidate/v1` d9f652f	`codex/cloud-problem-...` ed10157	+/-
`airbyte/cloud/connectors.py`	51%	80%	+29%
`airbyte/mcp/cloud.py`	52%	83%	+31%
`airbyte/mcp/_datadog.py`	0%	50%	+50%
`airbyte/mcp/int..._registry_ui.py`	0%	92%	+92%
`airbyte/mcp/_user_identity.py`	0%	93%	+93%
`airbyte/_direct...ctors/models.py`	0%	94%	+94%
`airbyte/mcp/_telemetry.py`	0%	94%	+94%
`airbyte/mcp/_sso_auth.py`	0%	96%	+96%
`airbyte/cloud/models.py`	0%	97%	+97%
`airbyte/mcp/int...nc_status_ui.py`	0%	97%	+97%

Python / code-coverage/pytest-unit

The overall line coverage in commit ed10157 in the codex/cloud-problem-... branch is 75%. Line coverage data for the release-candidate/v1 branch is not yet available.

Show a line coverage summary of the most covered files.

File	`release-candidate/v1`	`codex/cloud-problem-...` ed10157	+/-
`airbyte/cloud/models.py`	—	97%	—
`airbyte/mcp/_sso_auth.py`	—	96%	—
`airbyte/_direct...ctors/models.py`	—	94%	—
`airbyte/cloud/client.py`	—	90%	—
`airbyte/exceptions.py`	—	89%	—
`airbyte/mcp/cloud.py`	—	83%	—
`airbyte/progress.py`	—	80%	—
`airbyte/cloud/connectors.py`	—	75%	—
`airbyte/_util/api_util.py`	—	68%	—
`airbyte/shared/...ql_processor.py`	—	68%	—

_{Updated October 13, 2026 15:24 UTC}

Caleb Evans (calebevans-ab) · 2026-10-13T03:17:12Z

Codex (@codex) review

chatgpt-codex-connector · 2026-10-13T03:17:26Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-13T16:53:30.557965Z	`ed10157`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review" or "Codex (@codex) security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 830c828fb2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Caleb Evans (calebevans-ab) · 2026-10-13T05:02:03Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc174fdeca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Caleb Evans (calebevans-ab) · 2026-10-13T05:35:16Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c2f1c929d1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Caleb Evans (calebevans-ab) · 2026-10-13T06:21:39Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64f0795dcf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Caleb Evans (calebevans-ab) · 2026-10-13T06:36:19Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 85054290f0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Caleb Evans (calebevans-ab) · 2026-10-13T07:02:34Z

Codex (@codex) review

Caleb Evans (calebevans-ab) · 2026-10-13T14:52:39Z

Codex (@codex) review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49d7324e03

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Caleb Evans (calebevans-ab) · 2026-10-13T16:49:48Z

Codex (@codex) review

chatgpt-codex-connector · 2026-10-13T16:53:28Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: ed101574d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

linear-code · 2026-10-13T16:58:14Z

PLAT-1518

Alexandre Girard (girarda)

<3 🪓

refactor(mcp): relay Cloud problem detail instead of fixed messages

b1fb644

test: keep oversized Cloud body case ID short on Windows

830c828

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread airbyte/_util/cloud_errors.py Outdated

fix: reject non-standard JSON constants in Cloud error bodies

dc174fd

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread airbyte/_util/cloud_errors.py

fix: reject unpaired surrogates in Cloud problem messages

c2f1c92

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread airbyte/_direct_connectors/api_util.py Outdated

fix: strictly decode raw Cloud error responses as UTF-8

64f0795

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread airbyte/_util/cloud_errors.py

Comment thread airbyte/_util/api_util.py

fix(mcp): redact caught Cloud errors and validate SDK bytes

8505429

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread airbyte/mcp/cloud.py

Comment thread airbyte/mcp/cloud.py

fix(mcp): format caught Cloud errors before building results

49d7324

Caleb Evans (calebevans-ab) marked this pull request as ready for review October 13, 2026 07:05

chatgpt-codex-connector Bot reviewed Oct 13, 2026

View reviewed changes

Comment thread airbyte/mcp/_error_handling.py

fix(mcp): redact bearer credentials case-insensitively

ed10157

Caleb Evans (calebevans-ab) requested review from Aaron ("AJ") Steers (aaronsteers) and Alexandre Girard (girarda) October 13, 2026 20:25

Alexandre Girard (girarda) approved these changes Oct 13, 2026

View reviewed changes

Caleb Evans (calebevans-ab) merged commit 84c2f1c into release-candidate/v1 Oct 13, 2026
29 checks passed

Caleb Evans (calebevans-ab) deleted the codex/cloud-problem-detail-relay branch October 13, 2026 20:37

devin-ai-integration Bot mentioned this pull request Oct 17, 2026

docs(mcp): explain conflicting destination streams in create_connection_on_cloud and point to table_prefix #1404

Open

Aaron ("AJ") Steers (aaronsteers) mentioned this pull request Oct 17, 2026

fix(cloud): keep PyAirbyte guidance on run_cloud_sync 409s and report the running job ID #1405

Open

Conversation

Caleb Evans (calebevans-ab) commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

github-actions Bot commented Oct 13, 2026

👋 Greetings, Airbyte Team Member!

Testing This PyAirbyte Version

PR Slash Commands

Helpful Resources

Community Support

Uh oh!

github-code-quality Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Overview

Python / code-coverage/pytest-no-creds

Python / code-coverage/pytest

Python / code-coverage/pytest-unit

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 13, 2026

Uh oh!

linear-code Bot commented Oct 13, 2026

Uh oh!

Alexandre Girard (girarda) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Caleb Evans (calebevans-ab) commented Oct 13, 2026 •

edited

Loading

github-code-quality Bot commented Oct 13, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 13, 2026 •

edited

Loading