Skip to content

chore: DO NOT MERGE - source-faker with CDK dev image (memory leak test) - #75609

Closed
devin-ai-integration[bot] wants to merge 6 commits into
masterfrom
devin/1774896822-source-faker-memory-leak-test
Closed

devin-ai-integration[bot] wants to merge 6 commits into
masterfrom
devin/1774896822-source-faker-memory-leak-test

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Mar 30, 2026 •

Copy link
Copy Markdown
Contributor

What

⚠️ DO NOT MERGE — This PR is a test vehicle only.

Pins source-faker's airbyte-cdk dependency to a prerelease dev version that includes an intentional memory leak (from airbyte-python-cdk#969). This will be used to create a dev image of source-faker and test the CDK's memory monitor dual-condition fail-fast via actor pinning.

The dev CDK version duplicates each consumed record 500× into a growing list, inflating process anonymous RSS (RssAnon). This should trigger the dual-condition fail-fast (cgroup ≥ 98% and RssAnon ≥ 90%).

Companion PR: #75610 (cache pressure / negative case)

How

  • pyproject.toml: pins airbyte-cdk from >=6.61.6,<7.0 to ==7.13.0.post12.dev23757385016 (dev build from CDK PR Update connector READMEs to reflect new build plugin commands #969)
  • metadata.yaml + pyproject.toml: bumps dockerImageTag/version from 7.0.3 → 7.0.4 (required to pass the Connector Version Increment pre-release check)
  • Base image remains python-connector-base:4.0.2 (unchanged from master)

Updates since last revision

Reverted the earlier approach of swapping the base image to source-declarative-manifest. That caused Docker build failures because source-faker is a Python connector (not manifest-only) and the shared Dockerfile.python-connector runs apt-get which requires root. Instead, we now pin the airbyte-cdk dependency to the dev version directly.

Review guide

  1. airbyte-integrations/connectors/source-faker/pyproject.toml — CDK version pin + version bump
  2. airbyte-integrations/connectors/source-faker/metadata.yaml — version bump only (base image unchanged)

Human review checklist

User Impact

None — this PR should not be merged. It exists solely to produce a dev image of source-faker for testing the memory fail-fast feature via actor-level version pinning.

Can this PR be safely reverted and rolled back?

  • YES 💚

Link to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb

…ry leak test)

Updates source-faker base image to use source-declarative-manifest
dev image 7.13.0.post12.dev23757385016 from CDK PR #969 (memory
fail-fast with intentional memory leak).

This is a test branch for validating the memory monitor dual-condition
check. DO NOT MERGE.

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@octavia-bot
octavia-bot Bot marked this pull request as draft March 30, 2026 18:54
@octavia-bot

octavia-bot Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Note

📝 PR Converted to Draft

More info...

Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy.

As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page.

To skip draft status in future PRs, please include [ready] in your PR title or add the skip-draft-status label when creating your PR.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
    • /bump-progressive-rollout-version - Bumps connector version with an RC suffix (2.16.10-rc.1) for progressive rollouts (enableProgressiveRollout: true).
      • Example: /bump-progressive-rollout-version changelog="Add new feature for progressive rollout"
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@github-actions

github-actions Bot commented Mar 30, 2026 •

Copy link
Copy Markdown
Contributor

source-faker Connector Test Results

13 tests   10 ✅  9s ⏱️
 2 suites   3 💤
 2 files     0 ❌

Results for commit a9690a9.

♻️ This comment has been updated with latest results.

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration

This comment was marked as outdated.

@pnilan

Patrick Nilan (pnilan) commented Mar 30, 2026 •

Copy link
Copy Markdown
Member

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-faker.
PR: #75609

Pre-release versions will be tagged as {version}-preview.d843839
and are available for version pinning via the scoped_configuration API.

View workflow run
❌ Pre-release Publish FAILED for source-faker.

… dev version (memory leak test)

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration devin-ai-integration Bot changed the title chore: DO NOT MERGE - source-faker with SDM dev image (memory leak test) chore: DO NOT MERGE - source-faker with CDK dev image (memory leak test) Mar 30, 2026
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@pnilan

This comment was marked as outdated.

…with anon/usage fix)

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@pnilan

Patrick Nilan (pnilan) commented Mar 31, 2026 •

Copy link
Copy Markdown
Member

/publish-connectors-prerelease

Pre-release Connector Publish Started

Publishing pre-release build for connector source-faker.
PR: #75609

Pre-release versions will be tagged as {version}-preview.0e0f2bc
and are available for version pinning via the scoped_configuration API.

View workflow run
Pre-release Publish: SUCCESS ✅

Docker image (pre-release):
airbyte/source-faker:7.0.4-preview.0e0f2bc

Docker Hub: https://hub.docker.com/layers/airbyte/source-faker/7.0.4-preview.0e0f2bc

Registry JSON:

…prerelease)

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@pnilan

Copy link
Copy Markdown
Member

Looks good in tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants