Repository navigation
chore: DO NOT MERGE - source-faker with CDK dev image (memory leak test) - #75609
devin-ai-integration[bot] wants to merge 6 commits into
Conversation
…ry leak test) Updates source-faker base image to use source-declarative-manifest dev image 7.13.0.post12.dev23757385016 from CDK PR #969 (memory fail-fast with intentional memory leak). This is a test branch for validating the memory monitor dual-condition check. DO NOT MERGE. Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
|
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
This comment was marked as outdated.
This comment was marked as outdated.
|
/publish-connectors-prerelease
|
… dev version (memory leak test) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
This comment was marked as outdated.
This comment was marked as outdated.
…with anon/usage fix) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
|
/publish-connectors-prerelease
|
…prerelease) Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
|
Looks good in tests |
What
Pins source-faker's
airbyte-cdkdependency to a prerelease dev version that includes an intentional memory leak (from airbyte-python-cdk#969). This will be used to create a dev image of source-faker and test the CDK's memory monitor dual-condition fail-fast via actor pinning.The dev CDK version duplicates each consumed record 500× into a growing list, inflating process anonymous RSS (
RssAnon). This should trigger the dual-condition fail-fast (cgroup ≥ 98% and RssAnon ≥ 90%).Companion PR: #75610 (cache pressure / negative case)
How
pyproject.toml: pinsairbyte-cdkfrom>=6.61.6,<7.0to==7.13.0.post12.dev23757385016(dev build from CDK PR Update connector READMEs to reflect new build plugin commands #969)metadata.yaml+pyproject.toml: bumpsdockerImageTag/version from7.0.3→7.0.4(required to pass the Connector Version Increment pre-release check)python-connector-base:4.0.2(unchanged from master)Updates since last revision
Reverted the earlier approach of swapping the base image to
source-declarative-manifest. That caused Docker build failures because source-faker is a Python connector (not manifest-only) and the sharedDockerfile.python-connectorrunsapt-getwhich requires root. Instead, we now pin theairbyte-cdkdependency to the dev version directly.Review guide
airbyte-integrations/connectors/source-faker/pyproject.toml— CDK version pin + version bumpairbyte-integrations/connectors/source-faker/metadata.yaml— version bump only (base image unchanged)Human review checklist
airbyte-cdk==7.13.0.post12.dev23757385016is available on PyPI and corresponds to CDK PR Update connector READMEs to reflect new build plugin commands #9697.0.4is not already in use onmasterUser Impact
None — this PR should not be merged. It exists solely to produce a dev image of source-faker for testing the memory fail-fast feature via actor-level version pinning.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/070ecb51ceee4f9189e1c09a83ba31cb