Repository navigation
ci: fix airbyte-ops: command not found in connector test secret fetch - #77130
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Conversation
PR #76867 migrated test-job secret fetch call sites from `airbyte-cdk secrets fetch` to bare `airbyte-ops secrets fetch` but the test jobs (jvm-connectors-test and non-jvm-connectors-test) do not install `airbyte-internal-ops` beforehand, so the runner fails with `airbyte-ops: command not found` (exit 127). PR #76867's body described the migration as `uvx airbyte-internal-ops secrets fetch`, which is what landed at the qa and registry-artifacts call sites that already `uv tool install airbyte-internal-ops` themselves. Match the stated intent by switching the two test-job call sites to the `uvx` form, which is self-installing and matches the same pattern used in adjacent workflows that don't pre-install `airbyte-internal-ops`.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a CI regression introduced in #76867 (
9c7f64a49a3) that breaks theFetch connector secretsstep on every PR withcreds-available == 'true'(i.e. PRs from this org, not forks).#76867's PR body described the migration as
airbyte-cdk secrets fetch→uvx airbyte-internal-ops secrets fetch, but the diff at the two test-job call sites inconnector-ci-checks.ymlended up as the bareairbyte-ops secrets fetchform. Theairbyte-opsexecutable is provisioned byuv tool install airbyte-internal-ops, which therun-qa-checks(line 444) andbuild-and-verify-artifacts(line 513) jobs do explicitly — but thejvm-connectors-testandnon-jvm-connectors-testjobs do not. Result: the step fails withairbyte-ops: command not found(exit 127) before the unit / integration tests run.Concrete failure: e.g. #77129 —
Test source-ashby Connectorjob, exit 127 at theFetch connector secretsstep.How
Match #76867's stated intent by switching the two test-job call sites to the
uvxform.uvxis self-installing per invocation and is already present in both jobs (astral-sh/setup-uvruns earlier). No additional install step needed, no behavioral change beyond getting the right binary on PATH.Review guide
.github/workflows/connector-ci-checks.yml— two-line change at thejvm-connectors-testandnon-jvm-connectors-testFetch connector secretssteps.User Impact
Unblocks CI on every PR with
creds-available == 'true'. No runtime behavior change for connector developers.Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/5c2ccf537b70486b9e6fbc974d26063e
Requested by: Aaron ("AJ") Steers (@aaronsteers)