Repository navigation
docs(source-google-ads): clarify v23 migration - #77726
Closed
devin-ai-integration[bot] wants to merge 1 commit into
Closed
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
devin-ai-integration
Bot
force-pushed
the
docs/auto/source-google-ads
branch
from
May 7, 2026 21:59
b5ab67b to
c221d65
Compare
Contributor
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
devin-ai-integration
Bot
force-pushed
the
docs/auto/source-google-ads
branch
from
May 25, 2026 13:06
21e62aa to
3effe18
Compare
Contributor
|
Closing because this PR is substantially flawed and has numerous factual inaccuracies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggering Context
Run triggered by: API request to run the connector docs playbook for merged commit
a4e4085f005df8e838f1f32bd3e6abab7def0a96.Relevant context: #73722 upgraded source-google-ads from Google Ads API v20 to v23 and bumped the connector to
5.0.0.Confidence impact: The merged PR and connector name made the scope clear, but the change is a breaking API-version upgrade, so the Triggering Context score is 4/5 rather than 5/5.
Documentation Confidence Assessment
Overall Confidence: 3/5 capped: breaking changes require human review
spec.json,manifest.yaml, andmetadata.yaml.5.0.0.What I Verified vs. What I Inferred
metadata.yamlmarks source-google-ads as certified withql: 400,sl: 300, version5.0.0, and a5.0.0breaking-change entry with upgrade deadline2026-06-09.spec.jsonexposes the programmatic config fields documented in the new Reference table, including required OAuth credential fields and optionalcustomer_id,customer_status_filter, date, custom query, conversion window, and concurrency fields.manifest.yamluses Google Ads API v23 endpoints and includes the TrueView metric names, campaign datetime fields, revised bidding-strategy primary keys, andsegments.ad_network_typein the affected built-in stream schemas.https://www.googleapis.com/auth/adwordsscope.5.0.0row for the triggering PR and confirmed the link text matches the PR URL.Areas of Concern
docs/integrations/sources/google-ads-migrations.md, so it needs breaking-change reviewer approval even though the PR only changes documentation.auto-merge.What
Clarifies documentation for the source-google-ads
5.0.0breaking change introduced by #73722.This PR also corrects the
5.0.0changelog date to the merge date of the triggering PR.How
5.0.0changelog date from2026-04-20to2026-05-25.segments.ad_network_typewas added to several built-in stream schemas and lists the affected streams.Review guide
docs/integrations/sources/google-ads.md— Reference table and5.0.0changelog date.docs/integrations/sources/google-ads-migrations.md—5.0.0migration-guide clarifications.User Impact
Users upgrading source-google-ads to
5.0.0get a more complete migration path for schema, custom-query, and primary-key changes caused by the Google Ads API v23 upgrade.Can this PR be safely reverted and rolled back?
Devin session