Skip to content

docs(source-google-ads): clarify v23 migration - #77726

Closed
devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
docs/auto/source-google-ads
Closed

devin-ai-integration[bot] wants to merge 1 commit into
masterfrom
docs/auto/source-google-ads

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

Triggering Context

Run triggered by: API request to run the connector docs playbook for merged commit a4e4085f005df8e838f1f32bd3e6abab7def0a96.

Relevant context: #73722 upgraded source-google-ads from Google Ads API v20 to v23 and bumped the connector to 5.0.0.

Confidence impact: The merged PR and connector name made the scope clear, but the change is a breaking API-version upgrade, so the Triggering Context score is 4/5 rather than 5/5.

Documentation Confidence Assessment

Overall Confidence: 3/5 capped: breaking changes require human review

Dimension Score Rationale
Code Comprehension 3/5 The connector is low-code with substantial custom Python, but the edited docs were verified against spec.json, manifest.yaml, and metadata.yaml.
API Documentation Quality 4/5 Google Ads has strong official docs for OAuth, developer tokens, GAQL, quotas, release notes, and version sunset dates, with minor gaps around some edge-case reporting behavior.
Change Scope & Risk 4/5 The diff is small and targeted: 25 additions and 4 deletions across reference, changelog, and migration-guide clarification.
Existing Doc Maturity 5/5 The existing docs are mature, with setup, sync modes, supported streams, custom GAQL guidance, performance notes, changelog, and migration-guide coverage.
Connector Sensitivity 0/5 This is a certified high-impact connector and the docs update touches a breaking-change migration guide for version 5.0.0.
Triggering Context 4/5 The task was triggered from a specific merged connector PR and commit, but the triggering change is a major API upgrade.

What I Verified vs. What I Inferred

  • Verified from code:
    • metadata.yaml marks source-google-ads as certified with ql: 400, sl: 300, version 5.0.0, and a 5.0.0 breaking-change entry with upgrade deadline 2026-06-09.
    • spec.json exposes the programmatic config fields documented in the new Reference table, including required OAuth credential fields and optional customer_id, customer_status_filter, date, custom query, conversion window, and concurrency fields.
    • manifest.yaml uses Google Ads API v23 endpoints and includes the TrueView metric names, campaign datetime fields, revised bidding-strategy primary keys, and segments.ad_network_type in the affected built-in stream schemas.
  • Verified from API docs:
    • Google Ads API v23 exists in the official release notes and field docs.
    • Google Ads API access uses OAuth 2.0 and the https://www.googleapis.com/auth/adwords scope.
    • Google Ads publishes developer-token access levels, quotas, and API version sunset dates; v20 has a tentative June 2026 sunset and v23 sunsets in February 2027.
  • Inferred:
    • I did not validate every historical changelog row; I validated the 5.0.0 row for the triggering PR and confirmed the link text matches the PR URL.
    • The migration-guide instructions are based on the documented schema and primary-key changes, not on a live upgrade of an existing Google Ads connection.

Areas of Concern

  • This PR intentionally edits docs/integrations/sources/google-ads-migrations.md, so it needs breaking-change reviewer approval even though the PR only changes documentation.
  • Because the confidence score is 3/5, I did not apply auto-merge.

What

Clarifies documentation for the source-google-ads 5.0.0 breaking change introduced by #73722.

This PR also corrects the 5.0.0 changelog date to the merge date of the triggering PR.

How

  • Adds a programmatic configuration Reference table for users configuring the connector through PyAirbyte, Terraform, or the Airbyte API.
  • Corrects the 5.0.0 changelog date from 2026-04-20 to 2026-05-25.
  • Clarifies that segments.ad_network_type was added to several built-in stream schemas and lists the affected streams.
  • Makes custom-query migration guidance more direct for users with removed or renamed Google Ads fields.
  • Expands the upgrade action required so users know why they must refresh schemas and clear data for affected streams.

Review guide

  1. docs/integrations/sources/google-ads.md — Reference table and 5.0.0 changelog date.
  2. docs/integrations/sources/google-ads-migrations.md — 5.0.0 migration-guide clarifications.

User Impact

Users upgrading source-google-ads to 5.0.0 get a more complete migration path for schema, custom-query, and primary-key changes caused by the Google Ads API v23 upgrade.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Note: I am an AI assistant (Devin) and have proposed these documentation updates based on a review of the connector source code and third-party API documentation. Reviewers may merge, modify, or close this PR as they see fit.


Devin session

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration Bot added area/documentation Improvements or additions to documentation team/documentation labels May 4, 2026
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
      • Bump types: patch (default), minor, major, major_rc, rc, promote.
      • The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
      • The promote type strips the RC suffix to finalize a release.
      • Example: /bump-version type=rc or /bump-version type=minor
    • /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 📝 AI Documentation:
    • /ai-docs-review - AI-powered documentation review for PRs with connector changes.
    • /ai-create-docs-pr - Creates a documentation PR for connector changes, stacked on the current PR.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@devin-ai-integration
devin-ai-integration Bot force-pushed the docs/auto/source-google-ads branch from b5ab67b to c221d65 Compare May 7, 2026 21:59
Comment thread docs/integrations/sources/google-ads.md Outdated
@devin-ai-integration devin-ai-integration Bot changed the title docs(source-google-ads): correct 4.2.6-rc.2 release date and consolidate OSS Manager-account note docs(source-google-ads): document concurrency setting and setup notes May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

Project:airbyte-docs
Status: ✅  Deploy successful!
Preview URL:https://airbyte-docs-7i8q1uqsq-airbyte-growth.vercel.app
Latest Commit:3effe18

Deployed with vercel-action

@devin-ai-integration
devin-ai-integration Bot force-pushed the docs/auto/source-google-ads branch from 21e62aa to 3effe18 Compare May 25, 2026 13:06
@devin-ai-integration devin-ai-integration Bot changed the title docs(source-google-ads): document concurrency setting and setup notes docs(source-google-ads): clarify v23 migration May 25, 2026
@ian-at-airbyte

Copy link
Copy Markdown
Contributor

Closing because this PR is substantially flawed and has numerous factual inaccuracies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/documentation Improvements or additions to documentation team/documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant