Repository navigation
fix(source-amazon-seller-partner): skip FATAL reports when checking for existing reports (5.7.6-rc.2) - #77800
Merged
octavia-bot-admin[bot] merged 2 commits intoMay 6, 2026
Conversation
…or existing reports (5.7.6-rc.2) Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Daryna Ishchenko (darynaishchenko)
marked this pull request as ready for review
May 6, 2026 13:27
Contributor
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
Anatolii Yatsuk (tolik0)
approved these changes
May 6, 2026
Collaborator
Author
|
/force-merge reason="long running integration tests for this source"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes oncall#11837 — the
ReportCreationRequester(introduced in #76093) checks for existing SP-API reports before creating new ones, but it was reusing FATAL reports. Since the manifest'sstatus_mappingmaps FATAL tofailed, the CDK retries the job, which finds the same FATAL report again, creating an infinite retry loop.How
_find_existing_report()(same logic as existing CANCELLED skip), so a new report is created instead of reusing a permanently failed one.5.7.6-rc.2.Review guide
components.py—_find_existing_report(): added FATAL skip block (mirrors CANCELLED skip), updated docstringsunit_tests/test_report_creation_requester.py— updated 3 existing tests and added 1 new test for FATAL skip behaviormetadata.yaml— version bump5.7.6-rc.1→5.7.6-rc.2docs/integrations/sources/amazon-seller-partner.md— changelog entryUser Impact
Connections that previously got stuck in an infinite retry loop when Amazon returned a FATAL report status will now correctly skip the failed report and create a new one.
Can this PR be safely reverted and rolled back?
Requested by Daryna Ishchenko (@darynaishchenko).
Link to Devin session: https://app.devin.ai/sessions/9973291e68ff44a4a18aa3986753f41f