Skip to content

fix(source-amazon-seller-partner): skip FATAL reports when checking for existing reports (5.7.6-rc.2) - #77800

Merged
octavia-bot-admin[bot] merged 2 commits into
masterfrom
devin/1778073738-fix-fatal-report-reuse
May 6, 2026
Merged

octavia-bot-admin[bot] merged 2 commits into
masterfrom
devin/1778073738-fix-fatal-report-reuse

Conversation

@darynaishchenko

Copy link
Copy Markdown
Collaborator

What

Fixes oncall#11837 — the ReportCreationRequester (introduced in #76093) checks for existing SP-API reports before creating new ones, but it was reusing FATAL reports. Since the manifest's status_mapping maps FATAL to failed, the CDK retries the job, which finds the same FATAL report again, creating an infinite retry loop.

How

  • Skip FATAL reports in _find_existing_report() (same logic as existing CANCELLED skip), so a new report is created instead of reusing a permanently failed one.
  • Updated class-level and method-level docstrings to reflect that both CANCELLED and FATAL reports are now filtered.
  • Updated unit tests to verify FATAL reports are skipped (not reused).
  • Bumped version to 5.7.6-rc.2.

Review guide

  1. components.py — _find_existing_report(): added FATAL skip block (mirrors CANCELLED skip), updated docstrings
  2. unit_tests/test_report_creation_requester.py — updated 3 existing tests and added 1 new test for FATAL skip behavior
  3. metadata.yaml — version bump 5.7.6-rc.1 → 5.7.6-rc.2
  4. docs/integrations/sources/amazon-seller-partner.md — changelog entry

User Impact

Connections that previously got stuck in an infinite retry loop when Amazon returned a FATAL report status will now correctly skip the failed report and create a new one.

Can this PR be safely reverted and rolled back?

  • YES 💚

Requested by Daryna Ishchenko (@darynaishchenko).

Link to Devin session: https://app.devin.ai/sessions/9973291e68ff44a4a18aa3986753f41f

…or existing reports (5.7.6-rc.2)

Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
      • Bump types: patch (default), minor, major, major_rc, rc, promote.
      • The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
      • The promote type strips the RC suffix to finalize a release.
      • Example: /bump-version type=rc or /bump-version type=minor
    • /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
  • 📝 AI Documentation:
    • /ai-docs-review - AI-powered documentation review for PRs with connector changes.
    • /ai-create-docs-pr - Creates a documentation PR for connector changes, stacked on the current PR.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@darynaishchenko
Daryna Ishchenko (darynaishchenko) marked this pull request as ready for review May 6, 2026 13:27
@github-actions

github-actions Bot commented May 6, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for airbyte-docs ready!

Project:airbyte-docs
Status: ✅  Deploy successful!
Preview URL:https://airbyte-docs-pnge7fmzs-airbyte-growth.vercel.app
Latest Commit:3efbf96

Deployed with vercel-action

@darynaishchenko

Daryna Ishchenko (darynaishchenko) commented May 6, 2026 •

Copy link
Copy Markdown
Collaborator Author

/force-merge reason="long running integration tests for this source"

Force-merge job started... Check job output.

Force merge successful! This PR has been merged.

@octavia-bot-admin
octavia-bot-admin Bot merged commit 8909ad8 into master May 6, 2026
50 checks passed
@octavia-bot-admin
octavia-bot-admin Bot deleted the devin/1778073738-fix-fatal-report-reuse branch May 6, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants