Skip to content

chore(destination-motherduck): drop /local path config from connection tests - #85337

Merged
Patrick Nilan (pnilan) merged 1 commit into
masterfrom
devin/1788474030-motherduck-drop-local-connection-test
Sep 3, 2026
Merged

Patrick Nilan (pnilan) merged 1 commit into
masterfrom
devin/1788474030-motherduck-drop-local-connection-test

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Sep 3, 2026 •

Copy link
Copy Markdown
Contributor

What

integration_tests/config.json (destination_path: /local/destination.duckdb, dummy API key) is declared as a connection test with status: succeed. Since airbytehq/airbyte-python-cdk#1085 the CDK's FAST standard tests assert the CONNECTION_STATUS reported by check inside the built container, and this scenario fails with PermissionError(13) on every airbyte-python-cdk PR (Check: destination-motherduck job).

How

Remove the integration_tests/config.json entry from acceptance_tests.connection; it remains the fixture for the spec test. check() for a /local/... path calls os.makedirs and opens the DuckDB file, which cannot succeed in the container test harness where /local is not a writable mount — a harness limitation rather than connector behavior worth asserting. The real connection path is still covered by secrets/config.json (currently failing separately because the stored MotherDuck token is rejected; that needs a credential rotation, not a code change).

Review guide

  1. airbyte-integrations/connectors/destination-motherduck/acceptance-test-config.yml

User Impact

None; test configuration only. No connector version bump.

Requested by Patrick Nilan in #ask-devin-ai.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Link to Devin session: https://app.devin.ai/sessions/cb8f553cd89a45599bc9cb37cd9abf33
Open in Devin Desktop: https://app.devin.ai/desktop/session/cb8f553cd89a45599bc9cb37cd9abf33?variant=devin


Important

Autopilot Progressive Rollout Enabled

Autopilot progressive rollouts are enabled for one or more connector(s) modified in this PR. Check the box below if you need to bypass normal rollout safety processes and release to all users immediately upon merge:

  • ⚡ Release immediately (bypasses automatic progressive rollout)

Note:

  • ⚠️ The above bypass option is for emergency/hotfix use only.
  • 🔗 You can monitor or manually advance a rollout at ops.internal.airbyte.ai.

…n acceptance tests

Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pnilan
Patrick Nilan (pnilan) marked this pull request as ready for review September 3, 2026 22:22
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

💡 Show Tips and Tricks

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • 🛠️ Quick Fixes
    • /format-fix - Fixes most formatting issues.
    • /bump-version - Bumps connector versions, scraping changelog description from the PR title.
      • Bump types: patch (default), minor, major, major_rc, rc, promote.
      • The rc type is a smart default: applies minor_rc if stable, or bumps the RC number if already RC.
      • The promote type strips the RC suffix to finalize a release.
      • Example: /bump-version type=rc or /bump-version type=minor
    • /bump-progressive-rollout-version - Alias for /bump-version type=rc. Bumps with an RC suffix and enables progressive rollout.
  • ❇️ AI Testing and Review (internal link: AI-SDLC Docs):
    • /ai-prove-fix - Runs prerelease readiness checks, including testing against customer connections.
    • /ai-canary-prerelease - Rolls out prerelease to 5-10 connections for canary testing.
    • /ai-review - AI-powered PR review for connector safety and quality gates.
    • /ai-breaking-change-review - Assists the breaking-change reviewers: whether the change needs to be breaking, destination data-loss risk, and whether the migration guide, metadata message, and docs let users upgrade safely.
  • 📝 AI Documentation:
    • /ai-docs-review - AI-powered documentation review for PRs with connector changes.
    • /ai-create-docs-pr - Creates a documentation PR for connector changes, stacked on the current PR.
  • 🚀 Connector Releases:
    • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-preview.{git-sha}) for all modified connectors in the PR.
    • /enable-autopilot-rollouts - Enables autopilot progressive rollouts for the modified connector(s) in the PR, remediating "autopilot rollouts not enabled for {connector-name}" auto-merge blockers. Sets defaultRolloutMode: autopilot and enableProgressiveRollout: true, preserving any existing autopilotConfig.
      • Optional args: connector=<CONNECTOR_NAME> (defaults to the modified connectors in the PR), strategy=fast|slow|default (defaults to fast).
      • Example: /enable-autopilot-rollouts or /enable-autopilot-rollouts connector=source-faker strategy=slow
  • ☕️ JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
  • 🐍 Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.
  • ⚙️ Admin commands:
    • /force-merge reason="<REASON>" - Force merges the PR using admin privileges, bypassing CI checks. Requires a reason.
      Example: /force-merge reason="CI is flaky, tests pass locally"
📚 Show Repo Guidance

Helpful Resources

📝 Edit this welcome message.

@pnilan
Patrick Nilan (pnilan) merged commit 56d0cef into master Sep 3, 2026
43 of 46 checks passed
@pnilan
Patrick Nilan (pnilan) deleted the devin/1788474030-motherduck-drop-local-connection-test branch September 3, 2026 22:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a minimal, valid YAML update limited to test configuration and directly addresses a known harness-related connection-test failure without impacting connector runtime behavior.

Pull request overview

Removes a failing /local/... connection fixture from the Destination MotherDuck acceptance test configuration to align with the CDK FAST standard tests’ in-container check status assertions (where /local isn’t writable).

Changes:

  • Dropped integration_tests/config.json from acceptance_tests.connection.tests (previously expected to succeed).
  • Kept integration_tests/config.json as the config fixture for the spec test while leaving the real connection path coverage via secrets/config.json.
File summaries
File Description
airbyte-integrations/connectors/destination-motherduck/acceptance-test-config.yml Removes the /local-based connection test entry while preserving the spec test fixture and the remaining secrets-based connection test.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Khiet Tam Nguyen (nktnet1) pushed a commit to nktnet1/airbyte that referenced this pull request Sep 4, 2026
…n tests (airbytehq#85337)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants