Repository navigation
chore(destination-motherduck): drop /local path config from connection tests - #85337
Conversation
…n acceptance tests Co-Authored-By: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, valid YAML update limited to test configuration and directly addresses a known harness-related connection-test failure without impacting connector runtime behavior.
Pull request overview
Removes a failing /local/... connection fixture from the Destination MotherDuck acceptance test configuration to align with the CDK FAST standard tests’ in-container check status assertions (where /local isn’t writable).
Changes:
- Dropped
integration_tests/config.jsonfromacceptance_tests.connection.tests(previously expected to succeed). - Kept
integration_tests/config.jsonas the config fixture for thespectest while leaving the real connection path coverage viasecrets/config.json.
File summaries
| File | Description |
|---|---|
| airbyte-integrations/connectors/destination-motherduck/acceptance-test-config.yml | Removes the /local-based connection test entry while preserving the spec test fixture and the remaining secrets-based connection test. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…n tests (airbytehq#85337) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: patrick.nilan@airbyte.io <patrick.nilan@airbyte.io>
What
integration_tests/config.json(destination_path: /local/destination.duckdb, dummy API key) is declared as aconnectiontest withstatus: succeed. Since airbytehq/airbyte-python-cdk#1085 the CDK's FAST standard tests assert theCONNECTION_STATUSreported bycheckinside the built container, and this scenario fails withPermissionError(13)on every airbyte-python-cdk PR (Check: destination-motherduckjob).How
Remove the
integration_tests/config.jsonentry fromacceptance_tests.connection; it remains the fixture for thespectest.check()for a/local/...path callsos.makedirsand opens the DuckDB file, which cannot succeed in the container test harness where/localis not a writable mount — a harness limitation rather than connector behavior worth asserting. The real connection path is still covered bysecrets/config.json(currently failing separately because the stored MotherDuck token is rejected; that needs a credential rotation, not a code change).Review guide
airbyte-integrations/connectors/destination-motherduck/acceptance-test-config.ymlUser Impact
None; test configuration only. No connector version bump.
Requested by Patrick Nilan in #ask-devin-ai.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/cb8f553cd89a45599bc9cb37cd9abf33
Open in Devin Desktop: https://app.devin.ai/desktop/session/cb8f553cd89a45599bc9cb37cd9abf33?variant=devin
Important
Autopilot Progressive Rollout Enabled
Autopilot progressive rollouts are enabled for one or more connector(s) modified in this PR. Check the box below if you need to bypass normal rollout safety processes and release to all users immediately upon merge:
Note: