Repository navigation
fix(destination-milvus): preserve platform state message id - #88972
Merged
octavia-bot-hoard[bot] merged 2 commits intoOct 14, 2026
Merged
octavia-bot-hoard[bot] merged 2 commits into
octavia-bot-hoard[bot] merged 2 commits into
Conversation
Co-Authored-By: Sunil Kuruba <sunil.kuruba@airbyte.io>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
Co-Authored-By: Sunil Kuruba <sunil.kuruba@airbyte.io>
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
Note Autopilot progressive rollouts are not enabled for the following modified connector(s):
This is a courtesy heads-up only — it does not block merge or fail any check. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
121
to
122
| | Version | Date | Pull Request | Subject | | ||
| |:--------| :--------- | :-------------------------------------------------------- | :-------------------------------------------------------------------------------------------------------------------------------------------------- | |
Contributor
There was a problem hiding this comment.
[markdownlint-fix] reported by reviewdog 🐶
Suggested change
| | Version | Date | Pull Request | Subject | | |
| |:--------| :--------- | :-------------------------------------------------------- | :-------------------------------------------------------------------------------------------------------------------------------------------------- | | |
| | Version | Date | Pull Request | Subject | | |
| | :-------- | :--------- | :-------------------------------------------------------- | :-------------------------------------------------------------------------------------------------------------------------------------------------- | |
Contributor
|
Contributor
|
![octavia-bot-admin[bot]](https://avatars.githubusercontent.com/u/59758427?s=60&v=4){kind=small}
octavia-bot-hoard
Bot
deleted the
devin/1792016307-destination-milvus-preserve-state-id
branch
October 14, 2026 22:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resolves https://github.com/airbytehq/oncall/issues/13391.
Since 0.0.61 (#84362, CDK bump to
>=7.7.0,<8.0.0for CVE-2025-68664), destination-milvus syncs fail on the platform withjava.lang.IllegalStateException: State message does not contain idafter the destination emits its first STATE message, committing 0 records. 0.0.60 is unaffected.The platform attaches a top-level
idto each STATE message and requires it on the STATE the destination echoes back. CDK 7.xAirbyteStateMessageis a serpyco-rs dataclass with no additional-properties support, soAirbyteMessageSerializer.load/dumpinDestination._parse_input_stream/Destination.runsilently drop theid. The CDK-level fix (airbytehq/airbyte-python-cdk#1134) is still an unmerged draft, so this is the same connector-local interim workaround already merged for destination-pinecone in #88612 — the CVE remediation stays (CDK version unchanged).How
In
destination_milvus/destination.py(identical to #88612):DestinationMilvus._parse_input_stream(override): loads each line withAirbyteMessageSerializerand, for STATE messages, stores any top-levelstatekeys that aren'tAirbyteStateMessagefields (e.g.id) on the state object in a private attribute.serialize_airbyte_message+DestinationMilvus.run(override): dump withAirbyteMessageSerializer, then merge those extra keys back intostatewithsetdefault(never overwrites known keys, so it stays correct once the CDK preserves extras itself).Writeryields input STATE objects unchanged, so the attribute reaches the output.Version 0.0.62 → 0.0.63 (patch), changelog updated.
Test Coverage
New
unit_tests/state_id_test.py(7 tests, ported from #88612): STREAM and GLOBAL stateidround-trip, full_run_writepath through the real CDKWriter(mocked indexer/embedder) emitting STATE withid,run()stdout containingid, no-extras state serializes identically to the CDK serializer, RECORD messages unaffected, invalid JSON lines skipped. Full connector unit suite: 20 passed.Review guide
destination_milvus/destination.pyunit_tests/state_id_test.pymetadata.yaml,pyproject.toml,docs/integrations/destinations/milvus.mdUser Impact
Syncs to Milvus on 0.0.63 no longer fail with "State message does not contain id"; users pinned to 0.0.60 can upgrade and get the CVE fix. Follow-up: once airbytehq/airbyte-python-cdk#1134 is released, bump the CDK and drop this override.
Can this PR be safely reverted and rolled back?
Link to Devin session: https://app.devin.ai/sessions/e180c91d7c2146298ae46659f55cf1da
Open in Devin Desktop: https://app.devin.ai/desktop/session/e180c91d7c2146298ae46659f55cf1da?variant=devin
Requested by: Sunil Kuruba (@sunil-kuruba)