Claude Opus 4.8 (10 Teams, 3 Agents/Team) Review Report#2
Open
ZenithClown wants to merge 1 commit into
Open
Conversation
1. [HIGH BUGFIX] `currency_mw` now enforces type↔subtype consistency via a composite FK
`(currency_type, currency_subtype)` → `currency_subtype_mw`; the standalone single-column
subtype FK is subsumed. A fiat/commodity currency can no longer reference a digital-only
subtype (e.g. `type='f'` + `subtype='c'`).
2. [HIGH BUGFIX] `*.wikidata_id` widened `varchar(8)` → `varchar(12)` on continent / region /
subregion / country / state / city. Wikidata Q-IDs for states and cities already exceed 8
characters (current entity count > 100M ⇒ up to "Q1xxxxxxxx" / 10 chars), so the old width
was silently truncating or rejecting valid inserts. (Publisher-shape change - coordinated
with the StocksDB subscriber.)
3. [HIGH BUGFIX] `forex_rate_tx` gains `ck_forex_distinct_currency` (base ≠ target) and
`ck_forex_rate_positive` (`exchange_rate > 0`), rejecting nonsensical self-pairs and
non-positive rates.
4. [MEDIUM ENHANCEMENT] Geography hierarchy hardened with two composite FKs:
`country_mw.(region_code, subregion_code)` guarantees a country's region matches its
subregion's region; `city_mw.(country_code, state_uuid)` guarantees a city's country matches
its parent state's country (closes the intentional-denormalization integrity gap).
5. [LOW ENHANCEMENT] `geoname_id` widened to `varchar(12)` for headroom/consistency; lat/long
range checks added to state & city; `data_source_uri` bare-URL / no-credential note added for
parity with `stocksdb` / `tradesdb`.
⚙️ Reference PR: aivenio/project.archon#2
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ZenithClown
added
pr/blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference PR: aivenio/project.archon#2