Repository navigation
Establish task-tailored CSE function and sequence quality checks - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSE skills currently leave function naming, requested decomposition levels, and participant-exchange timing implicit. This change establishes proportionate guidance across the three independently invocable skills and adds opt-in documentary structure checks through
cse.py check --view-profile.A requested hierarchy now declares its level-0 root, levels, and parent links; missing requested levels/IDs, orphaned nodes, cycles, and duplicate identities cannot pass. Task profiles configure counts and coverage without universal breadth/depth requirements. Sequences declare native participants and ordered exchanges; modeled timing uses finite numeric ranges, units, and a basis, and becomes required only when the task profile says so. Justified profile exceptions remain visible. Action meaning, exchange usefulness, and engineering completeness explicitly require human assessment rather than a verb dictionary.
Existing unannotated SysML models and legacy JSON helpers retain their semantics. Native models remain authoritative; the new metadata establishes documentary structure, not native containment, behavior, or engineering acceptance. Read-only comparison against the unmerged foundation branch identified existing role/decomposition/source-diagram checks. When existing
cseWorkflowmetadata is present, the additive tree metadata must reconcile with its exact function identities and decomposition edges. This is bounded reconciliation, not full workflow/source validation. No renderer, visual-study files, or unpublished branch implementation is incorporated.Validation:
python3 -B scripts/check.py --require-sysml: all 203 tests across 14 suites passed without skips, including 29 new structural, negative, tailoring, CLI, native-parser, and workflow-reconciliation tests.git diff --check: clean. Examples and fixtures are entirely synthetic.Integration into the separate unpublished seven-skill foundation branch is not claimed by this PR. No merge is requested.