Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native parser checks failed on Windows because the adapter imported POSIX-only locking, used a POSIX classpath, and assumed Java output was UTF-8. Use nonblocking Windows byte-range or POSIX file locks, the platform classpath separator, and explicit UTF-8 byte transport. Missing or malformed output now returns a structured parser error. Lock acquisition and Java execution retain one timeout budget.
Add contention, exception/timeout recovery, Unicode and malformed-transport coverage, plus required-native CI on Ubuntu and Windows with Python 3.10/3.12 and Java 21. Windows checkout link records remain intact; launcher tests use the real skill directories when links are unavailable. The existing alpha scope remains three drafting skills sharing the pinned parser; project discovery and global installation require separate qualification.
Validation: Linux required-native suite passed 247 tests across 18 suites with no skips. Actual Windows qualification passed the same 247 tests, 12 focused portability tests and five launcher tests on Python 3.13.6 / Temurin 21.0.11, including a space/Unicode path. Independent code reviews found no remaining actionable findings. Optional helper checks also passed without Java, with the two native tests skipped.