Repository navigation
Remove hoists only used once - #33
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## faster-geometry-1 #33 +/- ##
====================================================
Coverage ? 65.80%
====================================================
Files ? 348
Lines ? 54839
Branches ? 3837
====================================================
Hits ? 36085
Misses ? 18358
Partials ? 396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akx
left a comment
akx
left a comment
There was a problem hiding this comment.
Minor comments, but I'm otherwise OK with this if it keeps the upstream PR moving.
| memset(out + x0, 0, (x1 - x0) * sizeof(pixel)); \ | ||
| } \ | ||
| if (yi >= 0 && yi < in_ysize) { \ | ||
| if (yi >= 0 && yi < imIn->ysize) { \ |
| for (x = x0; x < x1; x++) { | ||
| xin = COORD(xo); | ||
| if (xin >= 0 && xin < (int)in_xsize) { | ||
| if (xin >= 0 && xin < (int)imIn->xsize) { |
|
|
||
| #define XCLIP(im, x) (((x) < 0) ? 0 : ((x) < xsize) ? (x) : xsize - 1) | ||
| #define YCLIP(im, y) (((y) < 0) ? 0 : ((y) < ysize) ? (y) : ysize - 1) | ||
| #define XCLIP(x) (((x) < 0) ? 0 : ((x) < im->xsize) ? (x) : im->xsize - 1) |
There was a problem hiding this comment.
I think this would be good to have use an implicit ambient xsize too. It is being called multiple times in succession in e.g. BILINEAR_BODY/BICUBIC_BODY/..., so having xsize loaded into a local will pretty certainly help the compiler.
3 participants
Two suggestions for python-pillow#9788
XCLIPandYCLIPdon't needimpassed to them directly.