Conversation
Keys listed by the agent client come back as *agent.Key whatever their type, so the type assertion on *ssh.Certificate in loadIDs never matched. Certificate identities from the agent were treated as plain keys, and with IdentitiesOnly they were dropped because their fingerprint doesn't match the configured key. Connections to servers that require a certificate then failed with 'no key files found'. asCert now parses the key from its wire format before checking the type. certify uses it as well, for the same reason. Tested with a unit test for asCert, an e2e test that authenticates with a certificate only available through the agent, and manually with OpenSSH's ssh-agent against an sshd using TrustedUserCAKeys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keys listed by the agent client come back as *agent.Key whatever their type, so the type assertion on *ssh.Certificate in loadIDs never matched. Certificate identities from the agent were treated as plain keys, and with IdentitiesOnly they were dropped because their fingerprint doesn't match the configured key. Connections to servers that require a certificate then failed with 'no key files found'.
asCert now parses the key from its wire format before checking the type. certify uses it as well, for the same reason.
Tested with a unit test for asCert, an e2e test that authenticates with a certificate only available through the agent, and manually with OpenSSH's ssh-agent against an sshd using TrustedUserCAKeys.