Conversation
The daemon helper called cmd.Wait twice (once in the reaper goroutine, once in cancel), which the race detector flags. Cancel now waits on a channel closed by the reaper instead. The 500ms daemon startup timeout was too tight for the first run of a freshly linked binary on macOS and for -race builds, so bump it to 5s. Graceful termination is now polled instead of checked after a fixed 50ms sleep, and the keep-alive counter is read under its mutex.
daemonWithCancel returned an error on timeout but left the started process running, so a slow start leaked a daemon that outlived the test run.
TestTunnelReconnect checked for the reconnecting state right after dropping the server's connections and slept a fixed 500ms before expecting the tunnel to be back. Both depend on how fast the daemon notices, and the test failed on slower runs such as a -race build on Linux. It now polls 'list' for each state with a 10s deadline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.