Fix evidence test failures and clean up redundant tracker domains - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The evidence test could report missed trackers and still pass, and it never checked whether legitimate requests were blocked. It now fails on either mismatch and prints the fixture, URL, and expected result.
What changed
redundancyReason; unexplained overlaps stop generation before files are written.stats.g.doubleclick.netandstatic.ads-twitter.combecause they add different category signals.Blocking coverage and category coverage are unchanged. The audit table and contributor docs explain the decisions.
How tested
npm run generate:rulesnpm run test:evidence: all 60 request fixtures pass, including 44 tracker requests and 16 negative cases.npm run check: tooling tests, Decoy Mode tests, syntax, JSON, generated-file consistency, and safety checks pass.git diff --cached --checkNo UI changes. Browser tests were not run; the local evidence evaluator still has the third-party matching limitation tracked in #17.
Closes #13
Closes #21
Closes #22