Repository navigation
feat: configurable pane placement, direction, and popup via config.toml - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds user-editable pane-layout settings to the gitui plugin, closing the
"hardcoded --placement tab" gap: a flat-key
config.tomlin the plugin'sconfig directory (
HERDR_PLUGIN_CONFIG_DIR, else the guardedherdr plugin config-dir gituicallback) now controls where the gitui paneopens —
tab(default),split,overlay,zoomed, orpopup.Verified against the herdr 0.9.5 daemon:
split/zoomedrequire--target-pane(the caller pane) and must omit--workspace;overlay/popupmust omit
--workspace; a popup reply carries no pane id ({"type":"ok"})and the popup session must make no close calls, or it would close the user's
agent pane. All of that is specified, implemented, and pinned by tests. The
OpenSpec change
add-pane-placement-settingsis archived in the branch andits deltas are synced into the main specs. With no config the default argv is
byte-identical to 0.1.0. Version bumped to 0.2.0 in
Cargo.tomlandherdr-plugin.toml.Testing
cargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo test --locked(101 unit + 27 e2e, incl. placement/direction/popupargv, degradation paths, and the popup zero-close-call guarantee)
cargo build --release --lockednpx --yes prettier@3.9.6 --check "**/*.md"Plus manual smoke on herdr 0.9.5:
placement = "split"opens beside thecaller pane,
popupopens as a centered modal and closes with gitui.