Repository navigation
Conversation
Contributor
[Low impact] The changes affect the chat composer in the browser. Fix the restored-height overflow before merging; it can hide the side chat and its controls. FindingsFix with agent prompt### Issue 1
ui/src/components/ChatPanel.tsx:5061-5070
The saved height is not clamped when a composer mounts. Resize the main composer to 500px, then open a side chat in the half-height stacked pane. The side chat restores the same 500px height even though its pane is shorter. The composer cannot shrink, so it can hide the conversation and push its controls outside the pane. The `60vh` cap does not protect a half-height pane.
Clamp the height after mount and whenever the pane changes size, rather than only on `window.resize`.
### Issue 2
ui/src/components/ChatPanel.tsx:7464-7471
The new keyboard-adjustable `separator` exposes no current value or bounds. Screen-reader users can press the arrow keys, but cannot hear the resulting size or tell when they reach a limit. Add `aria-valuenow`, `aria-valuemin`, and `aria-valuemax`, keeping them aligned with the rendered height.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryAdds a persistent, resizable chat composer.
Reviews (1) · Last reviewed commit: "feat: make the chat composer resizable" · Reviewed by Greptile |
sBaydin
force-pushed
the
feat/resizable-composer
branch
from
November 3, 2026 09:23
9cce63e to
d6f6653
Compare
Contributor
|
@sBaydin do you reproduce the focus box for the bar being the entire width can you tune that to be custom to show the keyboard focus around the focus bar itself. if not ill send an image or just have ai fix it |
Contributor
Author
|
@paperclover Yeap reproducedit, the focus ring was on the full-width separator. Fixed focus now wraps the drag bar itself with a small offset ring. And also merged the latest and resolved the locale conflicts all checks pass. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #645
Summary
Scope
Test plan
node scripts/check-i18n.mjsnode scripts/check-styles.mjstsr generate && tsc --noEmitnode --test --experimental-strip-types tests/*.test.mjs(590 passing)vite buildcargo build --release --features desktop