Repository navigation
fix(ui): move the fast mode indicator to settings - #879
Merged
alphaxiv-bot[bot] merged 2 commits intoNov 4, 2026
Merged
Conversation
Keep the harness logo on the model picker and show the lightning indicator on the settings trigger that contains the Fast Mode toggle. Move the accessible fast-mode description to the same trigger. Assisted-by: gpt-6.1-sol
Contributor
[Low impact] The PR appears safe to merge. SummaryMoves the Fast Mode lightning icon and screen-reader label to the settings button in
No actionable issues found. Reviews (1) · Last reviewed commit: "fix(ui): move the fast mode indicator to..." · Reviewed by Greptile |
Contributor
|
thank you, perfect first contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #878
Summary
When Fast Mode is enabled, its lightning indicator appears on the model picker even though the toggle lives in the adjacent settings menu. Move the indicator and accessible Fast Mode description to the settings trigger, so users can follow the indicator to the control. Keep the harness logo on the model picker.
This is a presentation-only change in ModelPicker.tsx using existing localized messages and styling.
Test plan
Verified on commit e4e7fab:
pnpm build(includes localization checks, typecheck, and production build).pnpm lint:styles.pnpm test: all 590 existing UI tests passed.git diff --check.node dev.tsenvironment: GPT-6.1 Sol / XHigh; enabling Fast shows the lightning icon on settings, disabling it removes the icon, and the model logo remains.node dev.ts desktopusing isolated data: repeated Fast on/off, settings-trigger indicator, retained model logo, and model-menu opening verified. Accessibility inspection confirms the Fast Mode description belongs to the settings trigger and disappears when disabled.Native verification used the development app with the Vite-served UI, not a packaged release build. No model request was submitted; validation covers the UI behavior.
Assisted-by: gpt-6.1-sol