Skip to content

Create NHS Notify service - #6028

Merged
spatel033 merged 2 commits into
mainfrom
nhs-notify-the-beginning
Aug 11, 2026
Merged

Create NHS Notify service#6028
spatel033 merged 2 commits into
mainfrom
nhs-notify-the-beginning

Conversation

@spatel033

@spatel033 spatel033 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Add NHS Notify Org type and new service created by a member of the NHS Notify organisation is assigned to the NHS Notify organisation and has its org type should be nhs_notify and 0 text message allowance by default. More details on this card.
alphagov/notifications-api#4928 PR will be deployed first.

@spatel033
spatel033 force-pushed the nhs-notify-the-beginning branch from 369332e to ba99447 Compare August 4, 2026 13:55
@spatel033 spatel033 changed the title Nhs notify the beginning Create NHS Notify service Aug 4, 2026

@quis quis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a few places which render Service.organisation_type_label or Organisation.organisation_type_label. For example:

Organisation type: {{ service.organisation_type_label }}

"text": current_org.organisation_type_label or "Not set"

I think these will raise an exception for the NHS Notify org.

@spatel033
spatel033 force-pushed the nhs-notify-the-beginning branch 3 times, most recently from fbf0c2a to 14abb09 Compare August 10, 2026 13:39
This ensures that services that have this organisation type will see the
NHS branding as an option.
@spatel033
spatel033 force-pushed the nhs-notify-the-beginning branch from 14abb09 to 4e435a8 Compare August 10, 2026 13:40
@spatel033

Copy link
Copy Markdown
Contributor Author

There’s a few places which render Service.organisation_type_label or Organisation.organisation_type_label. For example:

Organisation type: {{ service.organisation_type_label }}

"text": current_org.organisation_type_label or "Not set"

I think these will raise an exception for the NHS Notify org.

Yes there was an exception for service.organisation_type_label and still returning ticket message with Organisation type: None. Updated both functions to handle missing nhs_notify type.

When member of the NHS Notify org create a service, it should be assigned to the NHS Notify org and should not see NHS service creation flow.
- Assign services created by NHS Notify org team members to the NHS
  Notify org
- Make sure there's no way that someone can select the NHS Notify org
  when creating or editing a service
- New NHS Notify service has an allowance of 0
@spatel033
spatel033 force-pushed the nhs-notify-the-beginning branch from 4e435a8 to bb3ef00 Compare August 10, 2026 13:56
@spatel033
spatel033 requested a review from quis August 10, 2026 14:06
@spatel033
spatel033 merged commit 5e075e2 into main Aug 11, 2026
8 checks passed
@spatel033
spatel033 deleted the nhs-notify-the-beginning branch August 11, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants