Fix fallback storage returning undefined for missing keys - #4867
Open
hamdyelbatal122 wants to merge 1 commit into
Open
Fix fallback storage returning undefined for missing keys#4867hamdyelbatal122 wants to merge 1 commit into
hamdyelbatal122 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4866
What was the issue?
When
localStorageis unavailable or throws an exception,$persistfalls back to an in-memoryMapstorage (dummy).When checking if a persisted key exists,
storageHas()ranstorage.getItem(key) !== null. BecauseMap.prototype.get()returnsundefined(unlikelocalStorage.getItem()which returnsnull),storageHas()returnedtruefor keys that were never set. This caused Alpine to attempt reading the value, receivingundefined, and overwriting the initial value passed to$persist().Changes made
dummystoragegetItemhandler to returnnullwhen a key is missing from the map, bringing it in line with the standardStorage.getItem()specification.storageHas()to check that the returned value is neithernullnorundefined.Verification
localStoragefunctionality — remains unchanged.localStoragethrows or is absent.