Skip to content

Keep overlay visible while transcribing - #793

Open
so1omon563 wants to merge 1 commit into
altic-dev:mainfrom
so1omon563:codex/issue-676-overlay-processing
Open

Keep overlay visible while transcribing#793
so1omon563 wants to merge 1 commit into
altic-dev:mainfrom
so1omon563:codex/issue-676-overlay-processing

Conversation

@so1omon563

Copy link
Copy Markdown

Description

Keep the normal dictation overlay visible in its existing “Transcribing” state until final transcription finishes, then hide it through the shared post-output lifecycle.

The regression came from a normal-dictation-only branch that requested an asynchronous overlay hide before asr.stop() began. Removing that special case lets normal dictation use the same processing lifecycle already used by AI, Command, Rewrite, prompt-test, and sandbox routes.

Type of Change

  • 🐞 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 🧹 Chore
  • 📝 Documentation update

Related Issue or Discussion

Closes #676.

Testing

  • Tested on Intel Mac
  • Tested on Apple Silicon Mac
  • Tested on macOS version: 26.5.2
  • Ran linter locally: swiftlint --strict --config .swiftlint.yml Sources (SwiftLint is not installed locally)
  • Ran formatter locally: swiftformat --config .swiftformat Sources (SwiftFormat is not installed locally)
  • Ran tests locally: xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'

Also verified with swiftc -parse, git diff --check, an unsigned app build, and a real normal-dictation stop cycle. Runtime benchmarks confirmed processing=true before asr.stop(), the overlay remained visible while final transcription ran, and hide began only after asr.stop() returned.

Screenshots / Video

Before: reporter’s screen recording showing the overlay disappearing before transcription completes.

  • No UI/visual changes; screenshots/video are not applicable.

Notes

This removes 19 net lines and adds no new state or abstraction.

AI assistance: Codex was used for implementation and validation.

@so1omon563
so1omon563 marked this pull request as ready for review August 5, 2026 17:29
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

The PR keeps the dictation overlay in its “Transcribing” state while final ASR processing completes, then routes normal dictation through the existing shared post-output hide lifecycle.

  • Removes the normal-dictation-only early overlay hide.
  • Unconditionally activates processing UI before awaiting asr.stop().
  • Simplifies empty and successful output cleanup to use the shared overlay lifecycle.

Confidence Score: 5/5

The PR appears safe to merge, with the normal dictation overlay now following the established processing lifecycle.

The changed stop path keeps processing active through final transcription and all reachable completion branches retain an explicit processing-state cleanup or intentional failure presentation.

Reviews (1): Last reviewed commit: "Keep overlay visible while transcribing" | Re-trigger Greptile

@altic-dev

Copy link
Copy Markdown
Owner

Hi is there a after video? I see the before video! Thank you! seems like a nice PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Normal dictation overlay hides before transcription and text insertion complete

2 participants