Keep overlay visible while transcribing - #793
Open
so1omon563 wants to merge 1 commit into
Open
Conversation
so1omon563
marked this pull request as ready for review
August 5, 2026 17:29
Greptile SummaryThe PR keeps the dictation overlay in its “Transcribing” state while final ASR processing completes, then routes normal dictation through the existing shared post-output hide lifecycle.
|
Owner
|
Hi is there a after video? I see the before video! Thank you! seems like a nice PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keep the normal dictation overlay visible in its existing “Transcribing” state until final transcription finishes, then hide it through the shared post-output lifecycle.
The regression came from a normal-dictation-only branch that requested an asynchronous overlay hide before
asr.stop()began. Removing that special case lets normal dictation use the same processing lifecycle already used by AI, Command, Rewrite, prompt-test, and sandbox routes.Type of Change
Related Issue or Discussion
Closes #676.
Testing
swiftlint --strict --config .swiftlint.yml Sources(SwiftLint is not installed locally)swiftformat --config .swiftformat Sources(SwiftFormat is not installed locally)xcodebuild test -project Fluid.xcodeproj -scheme Fluid -destination 'platform=macOS,arch=arm64'Also verified with
swiftc -parse,git diff --check, an unsigned app build, and a real normal-dictation stop cycle. Runtime benchmarks confirmedprocessing=truebeforeasr.stop(), the overlay remained visible while final transcription ran, and hide began only afterasr.stop()returned.Screenshots / Video
Before: reporter’s screen recording showing the overlay disappearing before transcription completes.
Notes
This removes 19 net lines and adds no new state or abstraction.
AI assistance: Codex was used for implementation and validation.