feat(tv): enable the four cable channels #21 left commented out - #108
Open
alycda wants to merge 1 commit into
Open
feat(tv): enable the four cable channels #21 left commented out#108alycda wants to merge 1 commit into
alycda wants to merge 1 commit into
Conversation
#21 added five cable channels but wired up only cheat.toml, commenting out jj-log/sqlite/postgres/redis with `# unverified`. The stated reason was the only reason: "Could not run `tv` in the build sandbox, so the channel schema is unverified." Nothing was wrong with the TOML. That check is runnable outside the sandbox, so I ran it against television 0.15.9 in the aarch64-linux dev container. All five files parse and resolve, and the three specific doubts #21 recorded are all settled in our favour: the per-file cable/*.toml layout is current (not the older single channels.toml), the placeholder is `{0}` not `{}`, and the [metadata]/[source]/[preview] split is right. For jj-log I checked the whole path end to end — the source command emits rows whose first token is the short change id, and `jj show <id>` accepts that token. Left deliberately unverified, and now said so in the comment rather than implied by a commented-out line: the macOS config path, and the DB channels' queries (sqlite3/psql/redis-cli are all absent here and there is no live DB). Only their schema was checked. That is safe to ship because each DB channel declares `requirements`, so it stays inert on a machine without its client instead of erroring. Worth knowing for anyone who ran the intermediate state: because these four were dropped from the generation, ~/.config/television/cable keeps four symlinks into a since-GC'd store path, so `tv jj-log` fails identically to a nonexistent channel. Activating a generation built from this commit is what repoints them; hand-patching the profile does not survive a restart. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
⊕ Entity-level changeshome-manager/modules/tools/television.nix
Summary: 2 modified across 1 file (1 modified orphan) functions and classes, not lines · sem |
alycda
marked this pull request as ready for review
August 17, 2026 06:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Uncomments the four
xdg.configFileentries forjj-log,sqlite,postgres, andredisinhome-manager/modules/tools/television.nix,and replaces the stale
VERIFY LOCALLYcomment with what was actuallyverified — and what still wasn't.
Why now
#21 added all five channel TOMLs but wired up only
cheat.toml. Thecommit message gives the sole reason:
That's a sandbox limitation, not a defect in the TOML — and it's
checkable outside the sandbox. I ran it against television 0.15.9
on aarch64-linux.
What I verified
All five files parse and resolve as channels. The three doubts #21
recorded are settled for 0.15.9:
channels.tomlwith[[cable_channel]]cable/*.tomlis current{}not{0}{0}is correct[metadata]/[source]/[preview]splitFor
jj-logI checked the full path: the source command emits rowswhose first whitespace-delimited token is the short change id, and
jj show <id>accepts that token — so{0}resolves correctly.What I did NOT verify
~/.config/televisionvs~/Library/...).sqlite3,psql, andredis-cliareall absent here and there's no live DB. Only their schema was
checked. This is safe to ship because each declares
requirements,so it stays inert on a machine without its client.
Both are now stated in the comment instead of being implied by a
commented-out line.
Side effect worth knowing
Anyone who ran the intermediate state has four
~/.config/television/cablesymlinks pointing into a since-GC'd store path, so
tv jj-logcurrentlyfails identically to a nonexistent channel. Activating a generation built
from this commit repoints them; hand-patching the profile doesn't survive
a restart.
Test plan
just lint(statix + deadnix) cleannix-instantiate --parseOKtv jj-logandtv cheatopen on a real machine🤖 Generated with Claude Code