Skip to content

Update Spanish translations and make hardcoded strings translatable - #2124

Merged
drtheodor merged 6 commits into
amblelabs:mainfrom
Peter1169:fix/missing-spanish-translations
Aug 22, 2026
Merged

Update Spanish translations and make hardcoded strings translatable#2124
drtheodor merged 6 commits into
amblelabs:mainfrom
Peter1169:fix/missing-spanish-translations

Conversation

@Peter1169

@Peter1169 Peter1169 commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

About the PR

This updates the Spanish translations and adds es_es.existing.json as the main Spanish translation source.

It also moves visible hardcoded strings into language keys, including screen text, renderer labels, command messages, actionbar messages, Handles responses, and several displayed registry names.

Why / Balance

Spanish had many missing or outdated translations, and some visible text could not be translated because it was hardcoded in code.

This keeps the Spanish localization more complete and also helps other languages translate those strings in the future.

Technical details

  • Added the es_es translation source.
  • Spanish regional locales continue to be generated from es_es.
  • Moved hardcoded visible strings to translation keys.
  • Added translatable display text with literal fallbacks for datapack-backed names.
  • Kept the default plaque text translatable while preserving custom and legacy plaque text as provided.
  • Removed duplicate language entries from existing translation files.

Media

N/A

Requirements

Breaking changes

N/A

Changelog
🆑

  • fix: Updated Spanish translations

@Peter1169
Peter1169 requested review from a team as code owners June 28, 2026 05:50
@github-actions github-actions Bot added S: Needs Review Status: Requires additional reviews before being fully accepted. size/M Denotes a PR that changes 100-999 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: Datagen Area: Datagen implementation & API. A: Tardis Components Area: Tardis components & manager. A: Engine Area: Tardis engine. A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. labels Jun 28, 2026
@GSMPBot
GSMPBot requested a review from drtheodor June 28, 2026 05:50
@github-actions github-actions Bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Jul 4, 2026
drtheodor
drtheodor requested changes Jul 5, 2026
View reviewed changes
Comment thread src/main/java/dev/amble/ait/client/renderers/decoration/PlaqueRenderer.java
Comment thread src/main/java/dev/amble/ait/core/commands/TeleportInteriorCommand.java Outdated
Comment thread src/main/java/dev/amble/ait/core/commands/TeleportInteriorCommand.java Outdated
Comment thread src/main/java/dev/amble/ait/core/commands/TeleportInteriorCommand.java Outdated
Comment thread src/main/java/dev/amble/ait/core/commands/TeleportInteriorCommand.java Outdated
Comment thread src/main/java/dev/amble/ait/data/schema/console/ConsoleTypeSchema.java
@GSMPBot
GSMPBot requested a review from drtheodor July 5, 2026 10:40
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions Bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Jul 17, 2026
@github-actions github-actions Bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted. label Jul 17, 2026
drtheodor
drtheodor requested changes Jul 31, 2026
View reviewed changes
Comment thread src/main/java/dev/amble/ait/client/util/TooltipUtil.java Outdated
Comment thread src/main/java/dev/amble/ait/core/blockentities/PlaqueBlockEntity.java Outdated
Comment thread src/main/java/dev/amble/ait/core/blockentities/PlaqueBlockEntity.java Outdated
Comment thread src/main/java/dev/amble/ait/core/blockentities/PlaqueBlockEntity.java Outdated
Comment thread src/main/java/dev/amble/ait/core/blockentities/PlaqueBlockEntity.java Outdated
Comment thread src/main/java/dev/amble/ait/data/schema/console/ConsoleTypeSchema.java Outdated
Peter1169 added a commit to Peter1169/ait that referenced this pull request Jul 31, 2026
@Peter1169
Merge latest upstream main into Spanish translation worktree
16de46d 
Temporary integration merge used to validate and package the fixes requested on amblelabs#2124.
@Peter1169
Peter1169 requested a review from drtheodor July 31, 2026 12:28
drtheodor
drtheodor approved these changes Aug 22, 2026
View reviewed changes

@drtheodor drtheodor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drtheodor
drtheodor merged commit 3aa3de1 into amblelabs:main Aug 22, 2026
1 of 2 checks passed
@drtheodor drtheodor added T: Cleanup Type: Code clean-up, without being a full refactor or feature. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. C: Translations and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. A: Tardis Components Area: Tardis components & manager. A: Engine Area: Tardis engine. labels Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drtheodor drtheodor drtheodor approved these changes

Assignees

No one assigned

Labels

A: Admin Tooling Area: Admin tooling and moderation. A: Console Area: Tardis console. A: Datagen Area: Datagen implementation & API. C: Translations S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Peter1169 @drtheodor