fix: honor --force on update to bypass local cache - #5
Open
DinonowDev wants to merge 2 commits into
Open
Conversation
The update command fired fetch without awaiting it, so the process could exit before available.json was written.
Skip re-fetch when available.json is fresher than one hour, unless --force is passed (also busts HTTP cache).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
available.jsonis fresher than one hour unless--forceis passed.--force, bypass local TTL and bust HTTP cache when refreshing the version list.Test plan
chvm updatetwice quickly and confirm the second run uses the cache messagechvm update --forceand confirm the list is refreshed~/.chvm/available.json