Repository navigation
Test against the upcoming spectra and spectral, store nil as jsonb null - #2
Merged
Merged
Conversation
Point spectral and spectra at their pre-0.17 git branches so everything can be tested together before release. Add a Postgres regression test that a nil field is stored as JSON null with nil_fields set to null. Update decimal to 3.2.0, and file the existing changelog entries under 0.1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
andreashasse
marked this pull request as ready for review
October 31, 2026 08:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: waiting for user feedback before merge and release. This is one of four aligned PRs. The Elixir ones depend on the others through git branches, so the whole set can be tried together. Nothing is released yet; the git dependencies go back to Hex versions after feedback. Depends on andreashasse/spectra#204 and andreashasse/spectral#47.
[:pre_encoded], so withnil_fields: :nullon spectral 0.16 it would have stored the string"null". A new Postgres test checks that anilfield is stored as jsonbnull(jsonb_typeof = 'null') and loads back asnil.mix.exstemporarily points:spectraland:spectraat their PR branches. Until they go back to Hex, thehex.buildstep inmake cifails, because Hex packages cannot depend on git. Every other step passes.decimalis updated to 3.2.0.[0.1.0], which matches the tag.Locally: 93 tests pass, and so do credo, dialyzer, the format check and
mix docs.🤖 Generated with Claude Code