Skip to content

docs(@angular/ssr): add SSRF security note to createNodeRequestHandle…#33370

Open
karthikrajanv2026 wants to merge 1 commit into
angular:mainfrom
karthikrajanv2026:docs/ssr-handler-ssrf-guidance
Open

docs(@angular/ssr): add SSRF security note to createNodeRequestHandle…#33370
karthikrajanv2026 wants to merge 1 commit into
angular:mainfrom
karthikrajanv2026:docs/ssr-handler-ssrf-guidance

Conversation

@karthikrajanv2026

Copy link
Copy Markdown

The Hono example in handler.ts uses createWebRequestFromNodeRequest() directly, which builds request.url from Host/X-Forwarded-* headers without host validation. Unlike AngularNodeAppEngine which documents allowedHosts and links to the SSRF security guide, this example carries no security guidance. This PR adds a @remarks note directing users to the existing SSRF documentation.

Reference: https://angular.dev/best-practices/security#preventing-server-side-request-forgery-ssrf

@google-cla

google-cla Bot commented Jun 14, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot Bot added area: docs Related to the documentation area: @angular/ssr labels Jun 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a security note to the documentation in 'packages/angular/ssr/node/src/handler.ts' regarding 'createWebRequestFromNodeRequest()'. It warns developers about potential Server-Side Request Forgery (SSRF) vulnerabilities when using unvalidated 'Host' and 'X-Forwarded-*' headers, and suggests proper configuration mitigations. There are no review comments, so I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: @angular/ssr area: docs Related to the documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant