fix: separate add-on entries in Tools menu with separator - #5124
Merged
Conversation
qais8r
marked this pull request as ready for review
July 8, 2026 14:52
qais8r
changed the title
GithubAnon0000
approved these changes
Jul 9, 2026
…arator # Conflicts: # CONTRIBUTORS
Contributor
Author
|
Hi! I’ve resolved the merge conflicts and updated the branch with the latest changes from |
Documentation build overview
4 files changed± genindex.html± autoapi/anki/collection/index.html± autoapi/aqt/mediasrv/index.html± autoapi/aqt/webview/index.html |
qais8r
changed the title
qais8r
changed the title
Contributor
|
It might take a while until a maintainer sees this. Thank you for your efforts. |
GithubAnon0000
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue (required)
Closes #5125
Summary / motivation (required)
Add a separator at the end of Anki's built-in Tools menu actions, before any add-on-provided menu entries.
Add-ons commonly append actions directly to
mw.form.menuTools. This keeps add-on entries visually separated from Anki's built-in Tools actions, especially on macOS where Preferences is shown elsewhere and add-on entries can appear immediately below "Check for Updates".Because Qt hides trailing menu separators by default, users without add-on-provided Tools menu entries should not see an extra separator.
Steps to reproduce (required, use N/A if not applicable)
How to test (required)
Checklist (minimum)
./ninja checkor an equivalent relevant check locally.Details
qt/aqt/forms/main.uias XML.git diff --check.Before / after behavior (optional)
Before: add-on-provided Tools menu entries can appear immediately after Anki's built-in actions.
After: add-on-provided Tools menu entries are visually separated from Anki's built-in actions.
Risk / compatibility / migration (optional)
Low risk. The change adds a Qt menu separator after the built-in Tools actions. Qt hides trailing menu separators by default, so users without add-on-provided Tools menu entries should not see an extra divider.
UI evidence (required for visual changes; otherwise N/A)
Scope