Repository navigation
nvidia-alchemi: document AIMNet2 as incomplete - #3
Open
faranm-stack wants to merge 1 commit into
Open
faranm-stack wants to merge 1 commit into
faranm-stack wants to merge 1 commit into
Conversation
The nvalchemi AIMNet2 wrapper disables the Coulomb and DFT-D3 terms that the
bundled aimnet2 checkpoint requires (its metadata sets needs_coulomb,
needs_dispersion and coulomb_mode sr_embedded), so load_model("aimnet2")
returns only the short-range neural-network term. On the bundled water
molecule the maximum force is 9.48 eV/A versus 0.68 eV/A from the aimnet
reference calculator, and a symmetric O-H stretch scan has no minimum below
1.10 A versus 0.959 A.
- Mark AIMNet2 as incomplete and experimental in the agent, tool and metadata
descriptions, the agent's potentials table, list_models() and the README.
- Add AIMNet2 to the workflows that require disclosure and explicit user
confirmation before use.
- Correct the AIMNet2 cache path in the agent instructions to
/opt/cache/aimnet/aimnet2_wb97m_d3_0.pt.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents AIMNet2 as incomplete and experimental in the
nvidia-alchemiagent, as agreed for microsoft#212, and corrects a stale AIMNet2 cache path in the agent instructions.Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Related issue / tracking
refs microsoft#212; follows #1 and #2.
Schema impact
breaking-changelabel and link the rollout plan belowValidation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).Reviewer notes (optional)
Why. The nvalchemi AIMNet2 wrapper disables the Coulomb and DFT-D3 terms (its docstring says to compose them separately), but the bundled
aimnet2checkpoint requires both: its metadata setsneeds_coulomb,needs_dispersionandcoulomb_mode: sr_embedded.load_model("aimnet2")therefore returns only the short-range neural-network term. On the bundled water molecule, compared with theaimnetpackage's reference calculator using its metadata defaults:load_model("aimnet2")aimnetreferenceThe agent path matches the reference calculator with Coulomb and D3 disabled (|ΔE| ≤ 4×10⁻⁴ eV, |ΔF| ≤ 6×10⁻⁷ eV/Å), and its forces match finite differences of its own energy, so the gap is the missing terms rather than the force calculation. The existing release checks (finite values, GPU/CPU agreement, rotation invariance) cannot detect this.
Changes (6 files, text only; no numerical code paths change):
/opt/cache/aimnet/aimnet2_wb97m_d3_0.pt, where nvidia-alchemi: hardening fixes and H100 revalidation for #212 #1 moved it.list_models()description, README verification status and coverage list, and CHANGELOG.Validation on this exact commit:
validate_pr.pyfrom currentmain, run against this branch merged withmain: passed, 0 failures.pip checkpassed; all three checkpoints loaded after hash verification; all 43 tests passed with no skips.Not changed: the AIMNet2 wrapper behaviour itself. Restoring the Coulomb and D3 terms by default, with the reference comparison above as a regression test, is a possible follow-up for the maintainers.