Tony/6 installer - #55
Merged
Merged
Conversation
tonypioneer
requested review from
gjwgit
and
a lite review from Copilot
and removed request for
Copilot
September 19, 2026 14:44
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Remove sensitive production logging and preserve error normalization alongside existing execution hooks.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Fixes macOS Developer ID login failures and improves authorization-code exchange error reporting.
Changes:
- Configures legacy macOS keychain storage.
- Adds token-store diagnostics.
- Preserves server details in authorization-code errors.
| File | Summary |
|---|---|
lib/src/auth/solid_token_store.dart |
Configures macOS keychain storage; production logging exposes sensitive authentication state and must be removed. |
lib/src/auth/solid_oidc_manager_factory.dart |
Normalizes authorization-code errors; normalization is bypassed when an existing execution hook is supplied. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+103
to
+104
| // TEMP DIAGNOSTIC - remove. | ||
| class _LoggingStore extends OidcDefaultStore { |
Comment on lines
+161
to
+166
| } on OidcException catch (e, st) { | ||
| final errorResponse = e.errorResponse; | ||
| if (errorResponse == null || | ||
| hookRequest.request.grantType != | ||
| OidcConstants_GrantType.authorizationCode) { | ||
| rethrow; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Fixed the issue that server refuses the request when login
Related Issues
gjwgit/todopod#6
Type of Change
How To Test?
Run GitHub Action to build dmg installer for macOS, and run the app on macOS.
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising