Tony/553 upload performance - #719
Open
tonypioneer wants to merge 4 commits into
Open
tonypioneer wants to merge 4 commits into
tonypioneer wants to merge 4 commits into
Conversation
…atch encryption-key updates
Contributor
|
Keep this for review for now - questions remain. |
cdawei
approved these changes
Sep 24, 2026
cdawei
left a comment
cdawei
left a comment
Collaborator
There was a problem hiding this comment.
The changes look good to me, thanks Tony.
Some additional clarification may help as mentioned in the comments.
| /// | ||
| /// [writePod] gives every encrypted file its own individual key and stores all | ||
| /// of them in one file, `encryption/ind-keys.ttl`, which has to be rewritten | ||
| /// in full whenever a key is added. Writing a batch of files one by one |
Collaborator
There was a problem hiding this comment.
This may need further clarification, see new issue #723
| /// Paths are interpreted exactly as [writePod] interprets its `filePath`, so | ||
| /// pass the same values (and the same [pathType]). Paths that already have a | ||
| /// key are skipped. A key registered here for a file that is never written is | ||
| /// harmless: it is simply unused. |
Collaborator
There was a problem hiding this comment.
Harmless only if there are not a lot of them...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
The fixes introduce HTTP connection reuse, remove redundant GET requests, batch encryption-key updates (solidpod), cache DPoP key parsing (solid_auth), and add concurrent reads/writes in HealthPod.
Related Issues
anusii/healthpod#553
Type of Change
How To Test?
Run the analysis.
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising