Repository navigation
feat(apisix): render extraContainers through tpl - #1003
Open
ahmedgabers wants to merge 1 commit into
Open
ahmedgabers wants to merge 1 commit into
ahmedgabers wants to merge 1 commit into
Conversation
extraContainers entries are raw container specs, so an image reference
inside them cannot be composed from other values the way first-class
image fields can. Rendering the list through tpl lets entries carry
template expressions (e.g. image: "{{ .Values.someRepository }}:{{ .Values.someTag }}"),
matching the common pattern for extra-container passthroughs. Plain
specs render unchanged.
Author
|
Fixes #1005. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extraContainers entries are raw container specs, so an image reference inside them cannot be composed from other values the way first-class image fields can. Rendering the list through
tpllets entries carry template expressions (e.g.image: "{{ .Values.someRepository }}:{{ .Values.someTag }}"), matching the common pattern for extra-container passthroughs. Plain specs render unchanged.Verified with
helm template: a templated entry expands correctly, and untemplated values render byte-identical to the current output. Chart version bumped 2.17.0 -> 2.17.1; values doc comment and README row updated.