Skip to content

Fix Control Ingress Creation - #783

Closed
alfredopalhares wants to merge 3 commits into
apache:masterfrom
alfredopalhares:bugfix/control-servicePort
Closed

alfredopalhares wants to merge 3 commits into
apache:masterfrom
alfredopalhares:bugfix/control-servicePort

Conversation

@alfredopalhares

Copy link
Copy Markdown

By default if you enable ingress for the control api the chart breaks, its checking bad place for the servicePort.

This fixes that, and add tests with helm- unittest, it currently only tests this exact situation, since i dont know if its something that the maintainers want. I can add more unitttest if you want.

Regards,
Alfredo Palhares

@kzmain

kzmain commented Feb 21, 2025

Copy link
Copy Markdown

Hi alfredopalhares, may I ask does our control api work well after you updated the code? I did the same fix as yours, and it shows 404 error per screenshot shows.
The helm command that I start the servies is:

helm repo add apisix https://charts.apiseven.com
helm repo update
helm upgrade --install apisix . \
--create-namespace --namespace apisix \
--set ingress.enabled=true \
--set ingress.className=nginx \
--set "ingress.hosts[0].host=apisix\.local" \
--set "ingress.hosts[0].paths[0]=\/" \
--set apisix.admin.enabled=true \
--set apisix.admin.ingress.enabled=true \
--set apisix.admin.ingress.className=nginx \
--set control.enabled=true \
--set control.ingress.enabled=true \
--set control.ingress.className=nginx \
--set ingress-controller.enabled=true \
--set ingress-controller.config.apisix.serviceNamespace=apisix

Screenshot 2025-02-22 at 03 09 56

@alfredopalhares

Copy link
Copy Markdown
Author

Hello, kzmain,

Mine does create that fine, did you use any extra settings ? What version of etcd are you using ?

@kzmain

kzmain commented Mar 4, 2025

Copy link
Copy Markdown

image
Per attachment shows, the version 3.5.18. I checked the pull history and the issue history, several guys have the same issue with me. I got solved my issue and I have done such code modification in this pull request. Thanks.

@Baoyuantop Baoyuantop added the bug Something isn't working label Apr 9, 2026
@AlinsRan AlinsRan closed this Sep 30, 2026
@AlinsRan AlinsRan reopened this Sep 30, 2026
@AlinsRan

Copy link
Copy Markdown
Contributor

Closing as superseded by #923, which has been merged with the same template change to ingress-control.yaml and service-control.yaml. Thanks for the original fix!

@AlinsRan AlinsRan closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants