Repository navigation
Fix Control Ingress Creation - #783
Closed
alfredopalhares wants to merge 3 commits into
Closed
alfredopalhares wants to merge 3 commits into
alfredopalhares wants to merge 3 commits into
Conversation
|
Hi alfredopalhares, may I ask does our control api work well after you updated the code? I did the same fix as yours, and it shows 404 error per screenshot shows. |
Author
|
Hello, kzmain, Mine does create that fine, did you use any extra settings ? What version of etcd are you using ? |
Contributor
|
Closing as superseded by #923, which has been merged with the same template change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


By default if you enable ingress for the control api the chart breaks, its checking bad place for the servicePort.
This fixes that, and add tests with helm- unittest, it currently only tests this exact situation, since i dont know if its something that the maintainers want. I can add more unitttest if you want.
Regards,
Alfredo Palhares