-
Notifications
You must be signed in to change notification settings - Fork 131
Add option to build and serve posts with dates in the future #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,6 +63,12 @@ site locally: | |
| bundle exec rake | ||
| ``` | ||
|
|
||
| To include posts with future dates: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are we changing to always allow future dates? If so we can probably remove this part too |
||
|
|
||
| ```shell | ||
| JEKYLL_FUTURE=1 bundle exec rake | ||
| ``` | ||
|
|
||
| ## Deployment | ||
|
|
||
| ### apache/arrow-site | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,11 +39,12 @@ end | |||||||
|
|
||||||||
| desc "Serve site locally" | ||||||||
| task :serve => webpacked_js do | ||||||||
| sh("jekyll", | ||||||||
| "serve", | ||||||||
| "--incremental", | ||||||||
| "--livereload", | ||||||||
| "--host", ENV["HOST"] || "127.0.0.1") | ||||||||
| command_line = ["jekyll", "serve"] | ||||||||
| command_line << "--incremental" | ||||||||
| command_line << "--livereload" | ||||||||
| command_line << "--host=#{ENV["HOST"] || "127.0.0.1"}" | ||||||||
| command_line << "--future" | ||||||||
| sh(*command_line) | ||||||||
| end | ||||||||
|
|
||||||||
| task :default => :serve | ||||||||
|
|
@@ -57,5 +58,7 @@ task :generate => webpacked_js do | |||||||
| command_line << "--config=_config.yml,#{extra_config}" if extra_config | ||||||||
| destination = ENV["JEKYLL_DESTINATION"] | ||||||||
| command_line << "--destination=#{destination}" if destination | ||||||||
| future = ENV["JEKYLL_FUTURE"] | ||||||||
| command_line << "--future" if future | ||||||||
|
Comment on lines
+61
to
+62
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can simplify this:
Suggested change
BTW, do we need this? If we need this, how about enable this only for preview? diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 9b963f13831..86236479f95 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -64,6 +64,9 @@ jobs:
export JEKYLL_DESTINATION=../build
export JEKYLL_ENV=production
export JEKYLL_EXTRA_CONFIG=_extra_config.yml
+ if [ "${GITHUB_REPOSITORY}" != "apache/arrow-site" ]; then
+ export JEKYLL_FUTURE=1
+ fi
bundle exec rake generate
- name: Checkout asf-site
uses: actions/checkout@v6 |
||||||||
| sh(*command_line) | ||||||||
| end | ||||||||
Uh oh!
There was an error while loading. Please reload this page.