ARTEMIS-6220 Emit scalar properties first - #6659
Open
lavocatt wants to merge 1 commit into
Open
Conversation
lavocatt
force-pushed
the
fixjsonorderinguri
branch
from
September 1, 2026 14:11
a738334 to
55d8e76
Compare
Split loadJsonObject/loadYamlMap into two passes — scalars first, then nested objects — so that discriminator values like uri are always set before a lazy-init getter (e.g. getTransportConfigurations) can fire during object path resolution. Without this, key ordering in the source file could cause silent data loss. Assisted-by: Claude Opus 4.6
lavocatt
force-pushed
the
fixjsonorderinguri
branch
from
September 1, 2026 16:10
55d8e76 to
6e08274
Compare
gtully
reviewed
Sep 2, 2026
| loadJsonEntries(keySurroundString, parentKey, jsonObject, true); | ||
| } | ||
|
|
||
| private void loadJsonEntries(String keySurroundString, String parentKey, JsonObject jsonObject, boolean objects) { |
Contributor
There was a problem hiding this comment.
a better variable name for 'boolean objects' possible, parseObjects? Just to ease understanding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split loadJsonObject/loadYamlMap into two passes — scalars first, then nested objects — so that discriminator values like uri are always set before a lazy-init getter (e.g. getTransportConfigurations) can fire during object path resolution. Without this, key ordering in the source file could cause silent data loss.
Assisted-by: Claude Opus 4.6 noreply@anthropic.com