Check Will publish permission on connect - #276
Merged
Gujiawei-Edinburgh merged 1 commit intoAug 26, 2026
Merged
Conversation
Gujiawei-Edinburgh
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me.
Gujiawei-Edinburgh
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A Will message is declared as part of the CONNECT packet, so its publish permission should be determined before the session is established.
Previously, the permission was checked only when the Will was about to be published. That could happen long after CONNECT and make the result depend on permission state at disconnect time.
Changes
Testing
Added MQTT 3 and MQTT 5 coverage for: