test: fail unexpected vacuous fallback-invariance checks - #5417
Open
sunchao wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Strengthens fallback-invariance tests to fail on unexpected binding gaps while preserving the known StringTranslate exception.
Changes:
- Classifies unexpected gaps as
FAIL-BIND. - Adds regression coverage for binding branches.
- Updates documentation and failure messaging.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
The suite added in #5329 checks outcomes only after proving that the default and forced-fallback legs exercised different execution paths. However, an unprovable comparison currently becomes
SKIPPED-VACUOUS, and the final assertion ignores those entries. The suite can therefore pass withpass=0 fail=0 vacuous=25, or stay green after losing an individual witness such asAddMonths.Unexpected coverage loss in this fixed regression corpus should fail the test instead of requiring someone to notice a changed counter in the logs. This is test-coverage enforcement, not a product behavior change; other suites also guard the historical
AddMonthsbug.Which issue does this PR close?
Follow-up to #5329 and its original issue, #5328. No new issue is closed.
What changes were proposed in this PR?
FAIL-BIND, which reaches the existing final assertion.values / StringTranslate / not-native-by-defaultas the known vacuous exception. IfStringTranslategains native support, it may pass normally; the test does not require a fixed skip count.Only
CometFallbackInvarianceSuite.scalachanges. No product code or CI workflow changes.How was this PR tested?
Rebuilt the native library from this upstream checkout with
cargo build --locked --offline, then ran the focused root Maven command on Spark 4.1.3 with JDK 17:./mvnw -o test -Dtest=none -Dsuites=org.apache.comet.CometFallbackInvarianceSuiteAll 6 ScalaTest tests passed, including the ten-scenario guard test in each of the three shuffle/C2R variants. The new guard test also failed in all three variants when compiled against the old implementation, before the binding fix.
Negative controls used the same upstream runtime in isolated JVMs. These counters were observed in every variant:
spark.comet.exec.project.enabled=falsespark.comet.expression.AddMonths.enabled=falseSpotless, scalastyle, and
git diff --checkpassed. Local runtime validation is Spark 4.1.3 only; the remaining Spark profiles are left to CI.