Update RAT excludes file path to work across all submodules - #124
Merged
Conversation
Use \${maven.multiModuleProjectDirectory} to reference .rat-excludes from
the project root so all submodules pick up the excludes configuration,
not just the root module.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use ${maven.multiModuleProjectDirectory} to reference .rat-excludes from the project root so all submodules pick up the excludes configuration, not just the root module.
Summary
The
.rat-excludesfile at the project root was only being picked up bythe root module. Submodules were ignoring it because the relative path
.rat-excludesresolved to each submodule's own basedir, where no suchfile exists.
Fix by using
${maven.multiModuleProjectDirectory}to reference theexcludes file from the project root in both
pom.xmlandparent-pom/pom.xml, so all submodules consistently use the sameexcludes list.
This ensures the
META-INF/services/*and other exclusions added in#123 are honoured when running
apache-rat:checkacross all modules.