[Fix-18565][API] Validate datasource access for task definitions - #18566
Merged
Conversation
ruanwenjun
force-pushed
the
fix-datasource-task-permission
branch
from
August 19, 2026 03:11
5ee6c22 to
166be76
Compare
det101
reviewed
Aug 19, 2026
SbloodyS
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. The implementation and tests were assisted by AI and reviewed locally.
Purpose of the pull request
Validate datasource access consistently before task definitions are saved or activated.
Closes #18565.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
./mvnw -pl dolphinscheduler-api -DskipE2E=true -DskipITs -Dspotless.check.skip=true -Dcheckstyle.skip=true -Dtest=TaskDatasourcePermissionCheckerTest,TaskDefinitionServiceImplTest,WorkflowDefinitionServiceTest,WorkflowInstanceServiceTest test../mvnw -pl dolphinscheduler-api -DskipTests spotless:checkpasses.