[Fix-16879] Remove parent VarPool from sub-workflow start params to prevent parameter duplication - #18575
Open
zhang-arvin wants to merge 1 commit into
Open
Conversation
…revent parameter duplication When multiple sub-processes exist in a parent workflow, the parent's accumulated VarPool was being merged into each sub-workflow's start parameters. This caused all sub-workflows to receive the same VarPool parameters, leading to parameter duplication and incorrect values in the sub-workflow's task instances. The fix removes the parent workflow's VarPool from the sub-workflow trigger parameters. Sub-workflows should only receive global params and command params from the parent. The sub-workflow's own tasks should generate their VarPool from within the sub-workflow's execution context. Closes apache#16879
zhang-arvin
requested review from
SbloodyS,
caishunfeng and
ruanwenjun
as code owners
August 20, 2026 16:04
SbloodyS
requested changes
Aug 21, 2026
SbloodyS
left a comment
SbloodyS
left a comment
Member
There was a problem hiding this comment.
Please follow the pull request template and fill in the form.
Author
|
@SbloodyS Thanks for the review! I have updated the PR description to follow the pull request template — added the header comment, the "Was this PR generated or assisted by AI?" section (NO), and corrected the section titles to match the template. Please take another look when you have a chance. |
Author
|
Thanks @SbloodyS, I'll update the PR description to follow the template. |
Author
|
Thanks @SbloodyS, I've updated the PR description to follow the template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
(Please describe the purpose of this pull request)
Brief change log
(Please list the changes made)
Verify this pull request
(Please pick either of the following options)
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests.
(or)
This change added tests and can be verified as follows:
(example:)
What changes were proposed
Remove parent workflow's VarPool from sub-workflow start parameters to prevent parameter pollution.
How was this patch tested
Manually verified by running sub-workflows with and without parent VarPool.