fix: handle negative depTaskCode in DependentItem.fromKey key parsing - #18577
Open
waterWang wants to merge 2 commits into
Open
fix: handle negative depTaskCode in DependentItem.fromKey key parsing#18577waterWang wants to merge 2 commits into
waterWang wants to merge 2 commits into
Conversation
When depTaskCode is -1 (DEPENDENT_ALL_TASK_CODE), getKey() produces
a key like "2001--1-day-today". The existing split("-") produces
5 parts instead of the expected 4, causing IllegalArgumentException.
Fix by detecting the 5-part pattern with empty second segment.
Closes apache#18576
waterWang
requested review from
Gallardot,
SbloodyS and
caishunfeng
as code owners
August 21, 2026 11:26
SbloodyS
requested changes
Aug 22, 2026
SbloodyS
left a comment
SbloodyS
left a comment
Member
There was a problem hiding this comment.
Please follow the pull request template and fill in the form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix
DependentItem.fromKey()to handle negativedepTaskCodevalues (i.e.,-1forDEPENDENT_ALL_TASK_CODE).Why are the changes needed?
When a Dependent task is configured with Task Name set to
ALL, the UI assignsdepTaskCode: -1. ThegetKey()method produces a key like"2001--1-day-today"(two consecutive hyphens).fromKey()splits on-, yielding 5 parts instead of the expected 4, causing:How were the changes tested?
Unit test covers:
"2001-123-day-today"→ 4 parts"2001--1-day-today"→ 5 parts, correctly parsed asdepTaskCode = -1IllegalArgumentExceptionDoes this pull request potentially affect one of the following parts:
Documentation
Closes #18576