[Improvement-18580][api] Fix typo in DataSourceServiceImpl log message - #18581
Open
kittimzhe wants to merge 2 commits into
Open
[Improvement-18580][api] Fix typo in DataSourceServiceImpl log message#18581kittimzhe wants to merge 2 commits into
kittimzhe wants to merge 2 commits into
Conversation
SbloodyS
reviewed
Aug 22, 2026
| schema = metaData.getConnection().getSchema(); | ||
| } catch (SQLException e) { | ||
| log.error("Cant not get the schema, datasourceId:{}.", datasourceId, e); | ||
| log.error("Cannot get the schema, datasourceId:{}.", datasourceId, e); |
Member
There was a problem hiding this comment.
Suggested change
| log.error("Cannot get the schema, datasourceId:{}.", datasourceId, e); | |
| log.error("Can not get the schema, datasourceId:{}.", datasourceId, e); |
Contributor
Author
There was a problem hiding this comment.
Done, thanks for the suggestion!
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was this PR generated or assisted by AI?
YES. The typo was identified with the help of an automated scan; the change itself is a one-word fix reviewed by the contributor.
Purpose of the pull request
Fixes #18580 — fix the "Cant not" typo in a log message of DataSourceServiceImpl.
Brief change log
DataSourceServiceImpl.java:Cant not get the schema→Cannot get the schemaVerify this pull request
This pull request is code cleanup without any test coverage.
(Log message only, no behavioral change; verified by diff inspection.)