Repository navigation
Conversation
Reject NaN and infinite connect/read/total timeout configuration, and use safe defaults at the HTTP client boundary when configuration validation is bypassed. Add configuration, client, and isolated loopback HTTP regressions showing that NaN cannot disable the total request deadline. Generated-by: OpenAI Codex (GPT-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject non-finite Doris HTTP connect/read/total timeout configuration. NaN previously passed validation and disabled the aiohttp total-request deadline. Direct client construction now falls back to existing safe defaults; finite positive values retain the 60-second runtime cap.
Validation
Entirely in Codex cloud: new tests on unchanged upstream had 12 failures and 4 passes; repaired HTTP tests 34 passed. Full suite 1879 passed, 85 skipped; coverage 68.14% and domain floors passed. Ruff, Mypy, Bandit, lockfile, generated catalog, build and clean-wheel checks passed. CI-pinned official MCP conformance: 25/25 passed. A real isolated loopback HTTP server was tested; real Doris integration was not run.
Limitations and AI assistance
Full license-eye scan could not run because its Go dependency download returned HTTP 403. All four changed Apache headers match baseline; no new dependencies. Upstream CI remains required. OpenAI Codex produced analysis, code, tests and this description. No human review or agreement signature is claimed. Draft for maintainer review.