Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

[EAGLE-740]Fix eagle-query checkstyle warnings#647

Open
koone wants to merge 2 commits into
apache:masterfrom
koone:EAGLE-740
Open

[EAGLE-740]Fix eagle-query checkstyle warnings#647
koone wants to merge 2 commits into
apache:masterfrom
koone:EAGLE-740

Conversation

@koone

@koone koone commented Nov 11, 2016

Copy link
Copy Markdown
Contributor

[EAGLE-740]Fix eagle-query checkstyle warnings

http://issues.apache.org/jira/browse/EAGLE-740

@haoch

haoch commented Nov 14, 2016

Copy link
Copy Markdown
Member

Classes under org.apache.eagle.query.antlr.generated is automatically generated by antlr, so suggest to exclude it from checkstyle and keep the original code.

@koone

koone commented Nov 14, 2016

Copy link
Copy Markdown
Contributor Author

revert eagle-antlr and exclude Classes under org.apache.eagle.query.antlr.generated from checstyle
@haoch could you please check again

@haoch

haoch commented Nov 14, 2016

Copy link
Copy Markdown
Member

Could you please rollback the code format of files under org.apache.eagle.query.antlr.generated too?

@koone

koone commented Nov 15, 2016

Copy link
Copy Markdown
Contributor Author

@haoch the last commit is already roolback the code format

@haoch

haoch commented Nov 15, 2016

Copy link
Copy Markdown
Member

@koone thanks

@haoch

haoch commented Nov 15, 2016

Copy link
Copy Markdown
Member

@koone As the PR changed too many files, please it may take a few days for reviewing.

@jhsenjaliya

Copy link
Copy Markdown
Contributor

@haoch , do you need any help on reviewing this?
@koone, Can you please rebase this PR ? Thanks

@jhsenjaliya

Copy link
Copy Markdown
Contributor

Hi @koone, This would be good to add in 0.5 branch, would you have time to rebase this and address comments from @haoch ? Thanks

@jhsenjaliya

Copy link
Copy Markdown
Contributor

I spent lot of time in rebasing this, but eventually it got very confusing since there are lot of files ( ~1500) to be rebased, which i did (jhsenjaliya:EAGLE-740-rebased) but there are multiple layers of rebase needs to be done, and i afraid i cant pick the right candidate wherever there are conflicts. so I am leaving this aside for 0.5 release, and we can get to this afterwards. this is important and we should take this change eventually. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants