You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Creating a table with a nested MAP/ROW column went through an Arrow schema, which affected timestamp/time precision, dropped column comments, and turned CHAR(n) into STRING. So it's better to fix it and use native converter and not Arrow schema's one.
Now the column types go to the server natively and are stored exactly as declared.
@charlesdong1991 Thank you for the review in fluss-rust, let's continue here then
Addressing comments, PTAL
does it hold true for Time? i think precision will change still for time?
Good catch — it was actually lossy, not just docs. Fixed: Time now carries precision end-to-end, so TIME(p) round-trips like TIMESTAMP(p). Added a test covering it.
so we will drop description? i guess it is intended?
Yes, it's better to leave it as follow-up(a lot of plumbing), also python also doesn't propagate for nested fields in ROW. Created an issue: #3604
Nit: since the targets are precision, comment and char, can we add an integration test that create a table with those type, and then assert get-table-info returns exactly those values?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from flus-rust repo
closes apache/fluss-rust#637
Creating a table with a nested MAP/ROW column went through an Arrow schema, which affected timestamp/time precision, dropped column comments, and turned CHAR(n) into STRING. So it's better to fix it and use native converter and not Arrow schema's one.
Now the column types go to the server natively and are stored exactly as declared.