Skip to content

feat(server): dedup partition writes with per-group client table slices - #3959

Open
numinnex wants to merge 3 commits into
masterfrom
rework_clients_table_one_more_time
Open

feat(server): dedup partition writes with per-group client table slices#3959
numinnex wants to merge 3 commits into
masterfrom
rework_clients_table_one_more_time

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

Implement deduplication for partition plane operations.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Aug 24, 2026
@numinnex

Copy link
Copy Markdown
Contributor Author

Merge after #3958

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.34993% with 77 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.48%. Comparing base (a65f177) to head (5949b88).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
core/shard/src/lib.rs 73.72% 24 Missing and 7 partials ⚠️
core/partitions/src/iggy_partition.rs 82.22% 21 Missing and 3 partials ⚠️
core/partitions/src/state_transfer.rs 92.55% 3 Missing and 4 partials ⚠️
core/consensus/src/client_table.rs 98.07% 4 Missing ⚠️
core/consensus/src/impls.rs 85.18% 3 Missing and 1 partial ⚠️
core/consensus/src/lib.rs 0.00% 3 Missing ⚠️
core/server/src/dispatch.rs 95.12% 1 Missing and 1 partial ⚠️
core/simulator/src/lib.rs 95.65% 1 Missing ⚠️
foreign/go/internal/vsr/envelope.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3959      +/-   ##
============================================
- Coverage     83.93%   81.48%   -2.45%     
+ Complexity     1358     1356       -2     
============================================
  Files          1213     1214       +1     
  Lines        168441   160410    -8031     
  Branches     135999   128098    -7901     
============================================
- Hits         141373   130712   -10661     
- Misses        23389    25684    +2295     
- Partials       3679     4014     +335     
Components Coverage Δ
Rust Core 81.76% <89.34%> (-2.96%) ⬇️
Java SDK 66.64% <100.00%> (-0.04%) ⬇️
C# SDK 75.06% <ø> (-1.46%) ⬇️
Python SDK 90.13% <ø> (ø)
PHP SDK 84.48% <ø> (ø)
Node SDK 95.90% <100.00%> (-0.01%) ⬇️
Go SDK 68.28% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
core/configs/src/server_config/defaults.rs 100.00% <100.00%> (ø)
core/configs/src/server_config/partition.rs 96.49% <100.00%> (+0.61%) ⬆️
core/partitions/src/iggy_partitions.rs 88.42% <100.00%> (+0.62%) ⬆️
core/sdk/src/quic/quic_client.rs 75.07% <ø> (ø)
core/sdk/src/vsr.rs 94.23% <100.00%> (+0.32%) ⬆️
core/server/src/bootstrap.rs 79.58% <100.00%> (+0.22%) ⬆️
core/server/src/http/submit.rs 87.93% <100.00%> (+0.12%) ⬆️
core/server/src/partition_helpers.rs 75.16% <100.00%> (+0.05%) ⬆️
core/shard/src/router.rs 72.59% <100.00%> (-0.97%) ⬇️
core/simulator/src/client.rs 65.89% <ø> (ø)
... and 15 more

... and 217 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review PR is waiting on a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant