fix(storage): import Codex item_completed messages - #3520
Draft
sunrioa wants to merge 1 commit into
Draft
Conversation
Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event_msg.item_completedrecords forUserMessage,Reasoning, andAgentMessage.user_messageandagent_*event shapes.event_msgas the presentation-message source so that correspondingresponse_itemmirrors are not imported twice.Fixes #3516
Refs #2499
Verification
codex-session-adaptersuite: 9 passed.NODE_NO_WARNINGS=1 npm --workspace @maka/storage run test:dist: 899 passed, 14 skipped.npm run lintnpm run format:checknpm run buildnpm run typechecknpm run check:asf-headersgit diff --checkWithout
NODE_NO_WARNINGS=1, one unrelated managed-dependency environment test treats Node.js's experimentalnode:sqlitewarning on child-process stderr as a failure. The full storage suite passes when that warning is disabled.Review focus
The adapter keeps the legacy and Codex 0.149 presentation formats side by side.
event_msgremains the authority for user, reasoning, and assistant presentation messages, whileresponse_itemremains responsible for tool calls and tool results. This preserves the existing duplicate-prevention boundary.AI use
Select exactly one:
Tool(s) and scope:
OpenAI Codex assisted with the rollout-format investigation, implementation, regression tests, local verification, and drafting this description. I reproduced the issue and reviewed the final diff, regression coverage, and test results before submission.
Checklist
Does this PR entail a change in behavior?